-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rules command to Adonis #1563
Conversation
adding terms that the user has to use adonis to display their games rules is a little bit.. eh imo, why are you forcing a rules command upon players when the game creator caries liability for bans issued? |
Right, maybe that was a bad idea |
Done |
I removed that |
Possibly remove the command when settings.Rules is set to nil? |
Would do the above myself but I can't seem to figure out how to suggest code with a new version inside of PR's. |
What is the point of not allowing game owners to remove this command? It is their game, not yours. Also, I don't think a rules command is even needed. |
A rules command is a good addition because of the new TOS coming with the Ban API (rules must be posted visibly in the game). The "not removing" part was already removed hence my reviewal and approval. |
You can remove the command with server.Commands.ViewRules = nil
server.Admin.CacheCommands() Only modifying the command is blocked. You can still remove or replace the command
That wouldn't work because of how Adonis settings work. It's possible to remove or replace the rules command with the above code snippet though with a plugin |
This still doesn't make sense in the main Adonis code base. Please convert this to a third party plugin. We already have plenty of settings. Don't get me wrong the feature is great and useful in some cases, but the cases where it is useful are quite rarw so i don't see that it should exist as a built-in feature. Hence I think you should convert this to a third party plugin |
see what i did there |
It's up to the game creator to decide how they want rules to be shown to players; this is typically done with a custom UI that integrates better with their game than Adonis, meant as an administration and moderation system, does. For those that want to leverage the UI and command framework of Adonis to achieve so, a separate plugin would be helpful. |
I think this is pointless, like Expert said it's up to the game creators to decide this stuff. Keep it as a plugin maybe for those interested but we shouldn't be overstepping our reach like that. |
Add rules command to Adonis