Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dashboard/experiments/database] make columns sortable, except non-singleton array columns #969

Merged
merged 1 commit into from
Jul 14, 2022
Merged

[dashboard/experiments/database] make columns sortable, except non-singleton array columns #969

merged 1 commit into from
Jul 14, 2022

Conversation

notoraptor
Copy link
Collaborator

Description

Hi @bouthilx ! This is a PR that allows to sort columns in experiment trials table.

Changes

  • Allow to sort by clicking on column header
  • A parameter column can be sorted either if parameter is not an array, or is an array with only 1 element in all trials.

Checklist

Tests

  • I added corresponding tests for bug fixes and new features. If possible, the tests fail without the changes
  • All new and existing tests are passing ($ tox -e py38; replace 38 by your Python version if necessary)

Documentation

  • I have updated the relevant documentation related to my changes

Quality

  • I have read the CONTRIBUTING doc
  • My commits messages follow this format
  • My code follows the style guidelines ($ tox -e lint)

@bouthilx bouthilx merged commit aef035b into Epistimio:develop Jul 14, 2022
@notoraptor notoraptor deleted the rearrange-columns branch July 20, 2022 06:18
@notoraptor notoraptor mentioned this pull request Aug 2, 2022
Merged
@bouthilx bouthilx added enhancement Improves a feature or non-functional aspects (e.g., optimization, prettify, technical debt) dashboard labels Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bouthilx bouthilx bouthilx approved these changes

Assignees
No one assigned
Labels
dashboard enhancement Improves a feature or non-functional aspects (e.g., optimization, prettify, technical debt)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@notoraptor @bouthilx