Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor refactor: Make creation of Experiment objects more explicit #968

Merged
merged 6 commits into from
Jul 15, 2022

Conversation

lebrice
Copy link
Collaborator

@lebrice lebrice commented Jul 11, 2022

  • Arguments are fully specified in Experiment.__init__. This is so we can avoid the current pattern of setting the attributes on the instance after it is initialized.
  • Adds type annotations to the arguments of Experiment.__init__ (and the attributes of Experiment objects), with typed dictionaries for the refers and metadata attributes. (Edit: Will be in another PR).
  • Add type annotations to some of the functions in experiment_builder.py
  • Raise a UserWarning if experiment_builder.create_experiment receives extra unused keyword arguments.

@lebrice lebrice force-pushed the lebrice/improve-experiment branch from 63f5f53 to 9acbc6e Compare July 11, 2022 21:25
@lebrice lebrice requested a review from bouthilx July 12, 2022 15:38
@lebrice lebrice merged commit 7eba478 into Epistimio:develop Jul 15, 2022
@lebrice lebrice deleted the lebrice/improve-experiment branch July 15, 2022 13:39
@notoraptor notoraptor mentioned this pull request Aug 2, 2022
@bouthilx bouthilx added the enhancement Improves a feature or non-functional aspects (e.g., optimization, prettify, technical debt) label Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves a feature or non-functional aspects (e.g., optimization, prettify, technical debt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants