Remove experiment from Trial hash #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is problematic to include experiment in trial hash since the experiment it belongs to is not known in advance in the algorithm object. In any case, we can make a unique index combining trial.hash + experiment.id so it is not necessary to hash the experiment.id. The trial has now trial.id, the hash of params+parent+fidelity and trial.id_override, the id corresponding to _id in legacy databases. trial.legacy_id is added to keep a backward compatible hash with previous versions of Oríon where trial.id included the experiment id in the hash.
bouthilx
added
the
enhancement
Why: When upgrading the DB to support index of (trial.id, trial.experiment), the DB will end up with a mixed format for the trial ids. The previous ids (_id) where the hash of the trials. It will now rely on the DB to generate the next _id. Thus, it will have string index mixed with integer values. It is best to keep ids as they were to better support backward compatibility (and Oríon version down-grade), so we should support mixed indexes. The bug was confusing anyway. How: Only consider integer indexes when inferring next id to use.
Delaunay
approved these changes
Jun 21, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is problematic to include experiment in trial hash since the
experiment it belongs to is not known in advance in the algorithm
object. In any case, we can make a unique index combining trial.hash +
experiment.id so it is not necessary to hash the experiment.id.
The trial has now trial.id, the hash of params+parent+fidelity and
trial.id_override, the id corresponding to _id in legacy databases.
trial.legacy_id is added to keep a backward compatible hash with
previous versions of Oríon where trial.id included the experiment id in
the hash.