-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config option frontends_uri
to specify allowed frontend addresses for Orion Web API
#811
Add config option frontends_uri
to specify allowed frontend addresses for Orion Web API
#811
Conversation
…pt CORS requests"" This reverts commit 776db96.
… server. Update test related to config file
Thanks! Ideally the conda packaging of falcon-cors should be integrated in our packaging pipeline to make sure we update it properly over time. However we should not expect to much changes in falcon-cors since last updates were 2 years ago. That leads me to another question; Is it a good idea to depend on this package, which does not seam maintained anymore, to address security concerns? I'm not sure... |
@bouthilx Indeed, it's an old package. Maybe I could just copy the code (with citation) directly into orion, as it's a matter of 2 classes (CORS + CORSMiddleware), so that we won't need any dependency anymore? |
For reference, after discussion with @notoraptor we decided to fork falcon-cors into @mila-iqia to maintain it ourselves. The code itself is not expected to evolve a lot since it is mostly just related to the CORS standard, but the tests may needs adjustments based on changes in falcon.testing.TestCase. We will also publish falcon-cors in the mila-iqia forge. |
@bouthilx PR updated, and conda package However, it seems I don't have rights on github |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good for this PR then, thanks!
Description
Hi @bouthilx ! This is a pull request to wrap all changes related to CORS handling for Orion Web API. I will close other related pull requests so that we can focus only on this one.
This PR adds option
frontends_uri
to list allowed frontend addresses and addfalcon-cors
dependencies for PYPI (using original package) and conda (using conda package I built from PYPI package and uploaded on my anaconda repo)Changes
frontends
to list allowed frontends for Orion server #782orion serve
#779Checklist
Tests
$ tox -e py38
; replace38
by your Python version if necessary)Documentation
Quality
$ tox -e lint
)Further comments
Please include any additional information or comment that you feel will be helpful to the review of this pull request.