Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove space upgrade from DB upgrade #627

Merged
merged 3 commits into from
Jul 23, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions src/orion/core/cli/db/upgrade.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
import sys

import orion.core.io.experiment_builder as experiment_builder
import orion.core.utils.backward as backward
from orion.core.io.database.ephemeraldb import EphemeralCollection
from orion.core.io.database.mongodb import MongoDB
from orion.core.io.database.pickleddb import PickledDB
Expand Down Expand Up @@ -126,7 +125,6 @@ def upgrade_documents(storage):
"""Upgrade scheme of the documents"""
for experiment in storage.fetch_experiments({}):
add_version(experiment)
add_space(experiment)
storage.update_experiment(uid=experiment.pop("_id"), **experiment)


Expand All @@ -135,11 +133,6 @@ def add_version(experiment):
experiment.setdefault("version", 1)


def add_space(experiment):
"""Add space to metadata if not present"""
backward.populate_space(experiment)


def update_indexes(database):
"""Remove user from unique indices.

Expand Down
1 change: 0 additions & 1 deletion tests/functional/backward_compatibility/test_versions.py
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,6 @@ def test_db_upgrade(self):

experiments = storage.fetch_experiments({})
assert "version" in experiments[0]
assert "priors" in experiments[0]["metadata"]

def test_db_test(self):
"""Verify db test command"""
Expand Down