Release candidate v0.1.15rc #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge back master in develop after release
Add presentations section in doc
We need to serialize the storage/DB config in order to transfer it to multiple workers.
There are many calls to `get_storage` in the code base that requires the singletons to be set. When serializing the experiment client to run multiple workers in parallel the singletons are not accessible in the other workers. We need to serialize them and reinstate them when deserializing. This is horribly messy but is required due to over-reliance on `get_storage()`. This is a bad design and we should get rid of it. See issue #606.
Serialize storage/DB and singletons.
Make Track serializable
Orion python api in parallel
Why: The workon pipeline was duplicated for the cli and python interface. The python interface should be reused instead under the hood for the CLI command. How: The consumer has been modified to serve only as a callable function to execute the users script. - The handling of interruption is moved to ExperimentClient.workon. - The fetching of results file is moved from storage to consumer since it is only relevant for the CLI. - The pacemaker is removed. The heartbeat is only defined and used within the ExperimentClient. Experiment.suggest was incoherent when experiment is done. It would return None, but the context manager could not work in such case. To handle this, suggest now raises CompletedExperiment instead of returning None.
Why: Now that cli hunt is using ExperimentClient.workon there is no need for code in worker. This code is only relevant for cli.hunt. This also solves a circular import issue.
Documentation for the visualizations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Features
🏗 Enhancements
huntcommand to reuseExperimentClient.workon@bouthilx (Refactorhuntcommand to reuseExperimentClient.workon#605)🐛 Bug Fixes
📜 Documentation