Skip to content

[WIP] Remove MongoDB dependency from core tests #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Apr 1, 2021
Merged

[WIP] Remove MongoDB dependency from core tests #582

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
6b6669d
Remove MongoDB dependencies from tests/functional/commands
breuleux Mar 29, 2021
0bb0c5e
Remove MongoDB dependencies from tests/functional/branching
breuleux Mar 29, 2021
9ba9e7a
Remove MongoDB dependencies from tests/functional/parsing
breuleux Mar 29, 2021
1fa5341
Remove MongoDB dependencies from tests/functional/demo
breuleux Mar 29, 2021
5b2970f
Remove MongoDB dependencies from tests/unittest/core (partial)
breuleux Mar 29, 2021
3d8a3b5
Fix formatting
breuleux Mar 30, 2021
a566afe
Remove MongoDB dependencies from tests/functional/client
breuleux Mar 30, 2021
2c2ae14
Remove MongoDB dependencies from tests/unittests/core/worker/test_pro…
breuleux Mar 30, 2021
385164b
Remove MongoDB dependencies from tests/unittests/core/io
breuleux Mar 30, 2021
a021142
Fix parent_id in child_config fixture
breuleux Mar 30, 2021
2720be0
Remove create_db_instance fixture
breuleux Mar 30, 2021
e1777b9
Remove database from yaml configs
breuleux Mar 30, 2021
97aa169
Change default storage to PickledDB
breuleux Mar 30, 2021
569dfd7
Remove MongoDB dependencies
abergeron Mar 30, 2021
93ed65d
Revert "Change default storage to PickledDB"
breuleux Mar 30, 2021
699012c
Revert "Remove database from yaml configs"
breuleux Mar 30, 2021
67ca3c7
Use storage instead of pdatabase in evc
breuleux Mar 31, 2021
6ad9a1c
Nuke test_experiment_tree
breuleux Mar 31, 2021
10e0126
Remove pdatabase
breuleux Mar 31, 2021
055e1e6
Remove more uses of _fetch_trials
breuleux Mar 31, 2021
40c3b00
Remove useless usefixtures
breuleux Mar 31, 2021
f1bceb0
Merge branch 'develop' into rm_mongo_dep
breuleux Mar 31, 2021
9b35f07
Avoid OrionState in hacked_exp fixture to fix storage fixture issue
breuleux Mar 31, 2021
10243f4
Fix database_test::TestReadOnlyDatabase.test_read
breuleux Mar 31, 2021
cbf9e86
Re-trigger tests
breuleux Mar 31, 2021
0f81bd9
Fix bug in update_heartbeat
breuleux Apr 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/orion/core/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ def define_database_config(config):
database_config.add_option(
"type",
option_type=str,
default="MongoDB",
default="PickledDB",
env_var="ORION_DB_TYPE",
help=(
"Type of database. Builtin backends are ``mongodb``, "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to change the host below as well. You should set it to default host for pickleddb: https://github.com/Epistimio/orion/blob/develop/src/orion/core/io/database/pickleddb.py#L25

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, right. Shouldn't the default here depend on the actual value of the type option? I mean, if type is set to mongodb then host should be localhost by default, not PickledDB's DEFAULT_HOST.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally yes, but Configuration does not support conditional defaults like this for the moment. :(

Copy link
Contributor Author

@breuleux breuleux Mar 30, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default could be None or "", though, and then the storage's constructor can set it to its default if it sees the host argument is null.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

Expand Down