Add max_broken in exp configuration #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bouthilx
force-pushed
the
feature/add_max_broken_exp_config
branch
2 times, most recently
from
da92cf0 to
e4288d4
Compare
The experiment was using `worker.max_broken` but max_broken for the experiment is also configurable and should be handled differently.
bouthilx
force-pushed
the
feature/add_max_broken_exp_config
branch
from
e4288d4 to
7d95cde
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The experiment was using
worker.max_brokenbut max_broken for theexperiment is also configurable and should be handled differently.