Return onehot interval instead of categorical #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bouthilx
force-pushed
the
feature/onehot_categorical_interval
branch
from
a881d65 to
45f987a
Compare
Why: When the categorical dimension is transformed to one-hot, the interval returned should be in the space of the one-hot otherwise the algorithm requesting a real space cannot handle the categories. How: Add an interval method to OneHot Transformer. TransformerDimension will look for an interval method, otherwise use the default interval of original dimension. Note that CompositeTransformer push the interval() method recursively if necessary, so that a one-hot encoding that is part of a composite transformer can still provide its interval().
bouthilx
force-pushed
the
feature/onehot_categorical_interval
branch
from
45f987a to
7ea196b
Compare
Codecov Report
@@ Coverage Diff @@
## develop #447 +/- ##
========================================
Coverage 49.47% 49.48%
========================================
Files 80 80
Lines 13808 13822 +14
Branches 348 348
========================================
+ Hits 6832 6840 +8
- Misses 6960 6966 +6
Partials 16 16
Continue to review full report at Codecov.
|
Thomsch
approved these changes
Aug 26, 2020
bouthilx
added a commit
to bouthilx/orion.algo.skopt
that referenced
this pull request
Aug 26, 2020
Why: Categorical used to return the categories even when there was a one-hot encoding of it. Since PR Epistimio/orion#447, the one-hot transformer now returns the proper interval in (0, 1) in vector of the size equal to number of dimensions.
This was referenced Nov 5, 2020
Closed
Closed
Merged
bouthilx
added a commit
to bouthilx/orion.algo.skopt
that referenced
this pull request
Dec 1, 2020
Why: Categorical used to return the categories even when there was a one-hot encoding of it. Since PR Epistimio/orion#447, the one-hot transformer now returns the proper interval in (0, 1) in vector of the size equal to number of dimensions.
bouthilx
added a commit
to bouthilx/orion.algo.skopt
that referenced
this pull request
Dec 4, 2020
Why: Categorical used to return the categories even when there was a one-hot encoding of it. Since PR Epistimio/orion#447, the one-hot transformer now returns the proper interval in (0, 1) in vector of the size equal to number of dimensions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
When the categorical dimension is transformed to one-hot, the interval
returned should be in the space of the one-hot otherwise the algorithm
requesting a real space cannot handle the categories.
How:
Add an interval method to OneHot Transformer.
TransformerDimension will look for an interval method, otherwise use the
default interval of original dimension.
Note that CompositeTransformer push the interval() method recursively if
necessary, so that a one-hot encoding that is part of a composite
transformer can still provide its interval().