Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring REST responses #446

Merged
merged 5 commits into from
Aug 24, 2020
Merged

Refactoring REST responses #446

merged 5 commits into from
Aug 24, 2020

Conversation

Thomsch
Copy link
Contributor

@Thomsch Thomsch commented Aug 21, 2020

Description

This pull request brings a few refactoring regarding where and how API responses are made to ensure a single point of maintenance and higher fidelity to the specification.

Changes

  • Reusable error titles
  • API responses are now all in responses.py
  • Resources tests files have the same name suffix

Checklist

Tests

  • All new and existing tests are passing ($ tox -e py38; replace 38 by your Python version if necessary)

Quality

  • I have read the CONTRIBUTING doc
  • My commits messages follow this format
  • My code follows the style guidelines ($ tox -e lint)

@Thomsch Thomsch added this to the v0.1.9 milestone Aug 21, 2020
@Thomsch Thomsch requested a review from bouthilx August 21, 2020 17:47
@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2020

Codecov Report

Merging #446 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #446   +/-   ##
========================================
  Coverage    49.47%   49.47%           
========================================
  Files           80       80           
  Lines        13808    13808           
  Branches       348      348           
========================================
  Hits          6832     6832           
  Misses        6960     6960           
  Partials        16       16           
Impacted Files Coverage Δ
...ts/functional/serving/test_experiments_resource.py 100.00% <ø> (ø)
tests/functional/serving/test_trials_resource.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5732d3...f1c2107. Read the comment docs.

@bouthilx bouthilx merged commit 9b6f4f9 into Epistimio:develop Aug 24, 2020
@Thomsch Thomsch deleted the refactoring-serving branch August 24, 2020 19:38
This was referenced Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants