Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid side effects in setup_storage #444

Merged
merged 1 commit into from
Aug 21, 2020

Conversation

bouthilx
Copy link
Member

Why:

The function was modifying the configuration dictionary, causing
side-effects if the user intended to reuse the configuration dictionary
later on.

Why:

The function was modifying the configuration dictionary, causing
side-effects if the user intended to reuse the configuration dictionary
later on.
@bouthilx bouthilx added bug Indicates an unexpected problem or unintended behavior low Superficial problem that doesn't affect the correctness (e.g., formatting, spelling, colors) labels Aug 21, 2020
@bouthilx bouthilx added this to the v0.1.9 milestone Aug 21, 2020
@bouthilx bouthilx requested a review from Thomsch August 21, 2020 13:37
@bouthilx
Copy link
Member Author

@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2020

Codecov Report

Merging #444 into develop will decrease coverage by 0.00%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #444      +/-   ##
===========================================
- Coverage    48.96%   48.96%   -0.01%     
===========================================
  Files           79       79              
  Lines        13644    13647       +3     
  Branches       328      328              
===========================================
+ Hits          6681     6682       +1     
- Misses        6947     6949       +2     
  Partials        16       16              
Impacted Files Coverage Δ
tests/unittests/storage/test_storage.py 16.18% <33.33%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a80eaa...e5ac0cd. Read the comment docs.

@Thomsch Thomsch merged commit 36033fb into Epistimio:develop Aug 21, 2020
This was referenced Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior low Superficial problem that doesn't affect the correctness (e.g., formatting, spelling, colors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants