Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort modules and extensions alphabetically #443

Merged
merged 1 commit into from
Aug 20, 2020
Merged

Sort modules and extensions alphabetically #443

merged 1 commit into from
Aug 20, 2020

Conversation

Thomsch
Copy link
Contributor

@Thomsch Thomsch commented Aug 20, 2020

Description

Unsorted extensions and modules list makes it hard to maintain and can cause merge conflicts when merged to develop.

Changes

This pull request sorts alphabetically:

  • The list of Sphinx extensions
  • The list of orion modules in setup.py
  • The list of orion modules in conda/meta.yaml

Checklist

Tests

  • All new and existing tests are passing ($ tox -e py38; replace 38 by your Python version if necessary)

Documentation

  • I have updated the relevant documentation related to my changes

Quality

  • I have read the CONTRIBUTING doc
  • My commits messages follow this format
  • My code follows the style guidelines ($ tox -e lint)

Unsorted list of extensions and modules makes it hard to maintain and merge back when concurrent changes are made.
@Thomsch Thomsch added the enhancement Improves a feature or non-functional aspects (e.g., optimization, prettify, technical debt) label Aug 20, 2020
@Thomsch Thomsch added this to the v0.1.9 milestone Aug 20, 2020
@Thomsch Thomsch requested a review from bouthilx August 20, 2020 19:38
@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2020

Codecov Report

Merging #443 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #443   +/-   ##
========================================
  Coverage    49.01%   49.01%           
========================================
  Files           81       81           
  Lines        13660    13660           
  Branches       329      329           
========================================
  Hits          6695     6695           
  Misses        6948     6948           
  Partials        17       17           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5d6fc9...7bff040. Read the comment docs.

@Thomsch Thomsch merged commit 4e5d0a0 into Epistimio:develop Aug 20, 2020
@Thomsch Thomsch deleted the module-order branch August 20, 2020 20:54
This was referenced Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves a feature or non-functional aspects (e.g., optimization, prettify, technical debt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants