Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST plotting endpoint with regret plots #438

Merged
merged 1 commit into from
Aug 17, 2020
Merged

REST plotting endpoint with regret plots #438

merged 1 commit into from
Aug 17, 2020

Conversation

Thomsch
Copy link
Contributor

@Thomsch Thomsch commented Aug 13, 2020

Description

This is the last foundational pull request for the REST API. It adds the /plots endpoint and serves regret plots as the first kind of plot available.

For more information, refer to #423.

Checklist

Tests

  • I added corresponding tests for bug fixes and new features. If possible, the tests fail without the changes
  • All new and existing tests are passing ($ tox -e py38; replace 38 by your Python version if necessary)

Documentation

  • I have updated the relevant documentation related to my changes

Quality

  • I have read the CONTRIBUTING doc
  • My commits messages follow this format
  • My code follows the style guidelines ($ tox -e lint)

@Thomsch Thomsch added the feature Introduces a new feature label Aug 13, 2020
@Thomsch Thomsch added this to the v0.1.9 milestone Aug 13, 2020
@Thomsch Thomsch requested a review from bouthilx August 13, 2020 17:42
@Thomsch Thomsch mentioned this pull request Aug 13, 2020
6 tasks
@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2020

Codecov Report

Merging #438 into develop will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #438      +/-   ##
===========================================
+ Coverage    48.95%   49.01%   +0.06%     
===========================================
  Files           80       81       +1     
  Lines        13640    13657      +17     
  Branches       329      329              
===========================================
+ Hits          6677     6694      +17     
  Misses        6946     6946              
  Partials        17       17              
Impacted Files Coverage Δ
tests/functional/serving/test_plots_resource.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3b982b...0df4d77. Read the comment docs.

Copy link
Member

@bouthilx bouthilx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 👌 🙂

@bouthilx bouthilx merged commit b185aaa into Epistimio:develop Aug 17, 2020
@Thomsch Thomsch deleted the feature/plots-web-api branch August 17, 2020 20:03
This was referenced Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Introduces a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants