Quit if code changed between two trials execution #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: We test the code version at beginning of experiment but it could change during an execution, leading to trials ran with different code versions. How: Validate before the execution of the trial that code version did not change. If so, raise BranchingEvent(). Note: There may be race conditions between the validation and the execution of the trial. The only solution for this would be to test the code version at beginning of trial execution but that would require reimplementation for all languages of users' scripts...
Thomsch
approved these changes
Jul 16, 2020
This was referenced Nov 5, 2020
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
We test the code version at beginning of experiment but it could change
during an execution, leading to trials ran with different code versions.
How:
Validate before the execution of the trial that code version did not
change. If so, raise BranchingEvent().
Note:
There may be race conditions between the validation and the execution of the trial.
The only solution for this would be to test the code version at
beginning of trial execution but that would require reimplementation for
all languages of users' scripts...