Convert functional algo tests to python API #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: The commandline API was adding a signicant overhead (>1s per calls). Migrating to python API reduce most test from 150s to 5s.
Why: Changing the seed has the effect of changing the configuration of the algorithm. How: Use the same root seed and only increment within set_rng based on number of repetitions. Note: No unittests are added since configuration of algos is automatically tested at end of functional tests.
Closed
Thomsch
approved these changes
Jul 2, 2020
Why: If workon fails, the new storage is kept and the previous one is lost. The previous one should be restored and the temporary EphemeralDB should be flushed. How: In workon, wrap the execution with a try-finally and revert storage in any case.
|
Failing backward-compatibility tests due to orion.core pypi project deletion. Fix coming in another PR. |
This was referenced Nov 5, 2020
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The commandline API adds a significant overhead for cheap functions to evaluate. In the functional tests for the algorithms, the executions for the trials represents more than 75% of the whole running time of tests, with each trial execution taking more than 1s. Converting these tests to the Python API reduced tests from 130s each to 5s.
Changes