Remove useless deprecation warnings #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #376 +/- ##
===========================================
- Coverage 45.23% 45.20% -0.03%
===========================================
Files 66 66
Lines 12412 12424 +12
Branches 306 306
===========================================
+ Hits 5614 5616 +2
- Misses 6773 6783 +10
Partials 25 25
Continue to review full report at Codecov.
|
Why: There was still access to deprecated options in the `core` which were triggering deprecation warnings event though the user was not using any of these. How: Adjust access to config to use the proper configuration values and update yaml reading to transfer deprecated settings to proper ones with warning for users.
bouthilx
force-pushed
the
fix/remove_useless_deprecation_warnings
branch
from
400f86a to
4593144
Compare
Thomsch
approved these changes
Apr 2, 2020
|
Sure :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
There was still access to deprecated options in the
corewhich weretriggering deprecation warnings event though the user was not using
any of these.
How:
Adjust access to config to use the proper configuration values
and update yaml reading to transfer deprecated settings to proper ones
with warning for users.