Handle trials with corrupted status #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bouthilx
added
bug
Why: The helper functions were in different modules which was confusing. Moving them to storage/base and storage/legacy makes it more coherent.
Why: The method fetch many trials, not only one, hence the name is confusing.
Why: Database corruption occurs when there is Timeouts in PickledDB. The objective is saved but status is not set to completed. How: We catch non-completed trials with objective and log a warning with a pointer to documentation to manually fix corrupted trials.
bouthilx
force-pushed
the
fix/handle_corrupt_trials_status
branch
from
f529bf8 to
e28a934
Compare
|
Closing and reopening to trigger build on travis-ci.com (migrated from travis-ci.org few minutes ago). |
Codecov Report
@@ Coverage Diff @@
## develop #372 +/- ##
===========================================
- Coverage 45.45% 45.22% -0.24%
===========================================
Files 67 67
Lines 12245 12388 +143
Branches 306 306
===========================================
+ Hits 5566 5602 +36
- Misses 6654 6761 +107
Partials 25 25
Continue to review full report at Codecov.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
Database corruption occurs when there is Timeouts in PickledDB. The objective is saved but status is not set to completed.
How:
We catch non-completed trials with objective and log a warning with a pointer to documentation to manually fix corrupted trials.
Note:
Also add substantial documentation on storage which was required to document what the user can do to fix the database corruption.