Fix broken-link in monitoring #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thomsch
added
documentation
bouthilx
reviewed
Mar 24, 2020
| @@ -1,7 +1,7 @@ | |||
| Iterative Results with EVC | |||
| -------------------------- | |||
|
|
|||
| When using the experiment version control (described `here <user/evc>`_), | |||
| When using the experiment version control (described :doc:`here <../../user/evc>`), | |||
There was a problem hiding this comment.
Thanks for the fix! Can you try with /user/evc instead? (for an absolute path)
There was a problem hiding this comment.
Great idea! I remember trying it but it didn't work at the time. In hindsight, it was probably a small syntax error. I tried again and it worked. It's much better this way 🙏.
Codecov Report
@@ Coverage Diff @@
## develop #366 +/- ##
========================================
Coverage 45.45% 45.45%
========================================
Files 67 67
Lines 12245 12245
Branches 306 306
========================================
Hits 5566 5566
Misses 6654 6654
Partials 25 25 Continue to review full report at Codecov.
|
Merged
|
Closing and re-opening because for some reason github didn't receive travis notice that tests passed. |
bouthilx
approved these changes
Mar 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
There is a broken link in the monitoring section when referencing the EVC. https://trello.com/c/HWp2LH8J
How:
I replaced the broken external link with a valid internal link. This way, if the linked document is moved, the build system will throw an error.