-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hyperband fixes #363
hyperband fixes #363
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #363 +/- ##
===========================================
- Coverage 45.55% 45.45% -0.11%
===========================================
Files 67 67
Lines 12270 12245 -25
Branches 318 306 -12
===========================================
- Hits 5590 5566 -24
+ Misses 6655 6654 -1
Partials 25 25
Continue to review full report at Codecov.
|
Great! 😃 I will look at the PR in details tonight or tomorrow. |
src/orion/algo/hyperband.py
Outdated
:mod:`orion.algo.hyperband.hyperband -- TODO | ||
================================================= | ||
:mod:`orion.algo.hyperband` -- A Novel Bandit-Based Approach to Hyperparameter Optimization | ||
============================================================================================ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
============================================================================================ | |
=========================================================================================== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM beside my few minor comments. Thanks! :)
Seems only osx test failed, maybe can try restart travis build @bouthilx |
trvais failed again. There seems a potential bug of space transformer when the lower/upper bound value suggested from the original space. |
Indeed. I saw this issue in the stress test I am implementing. I should fix it this week. |
This PR include below fixes for Hyerband:
Fix: Besides the fix, also add a debug log to show the budget table like this:
Duplicate points in a single hyperband execution will cause some points been tried but won't be able to register into the correct budget since we choose bracket one time based on fidelity.
Fix: Won't allow repeated points in a single hyperband execution. And if the search space is too small to fill the first rungs of all brackets, hyperband won't be able to promote and experiment only run the points of the first rungs and exit.
Support to run duplicate points in different hyperband execution only if the later one get bigger fidelity compared with previous execution.
When multiple workers run in parallel, there are 2 issues:
Fix: Sync the executed number of times from naive algorithm to source.
Fix: Try to refresh brackets of hyperband after observe of each point.
Add documentation for Hyperband
@bouthilx