Avoid duplicates in RandomSearch #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: The filtering of duplicates in RandomSearch is a lot more efficient than relying on the database with DuplicateKeyErrors. There will still be race conditions leading to this error, but filtering upfront in RandomSearch reduces significantly the number of registration failures and lead to better workload balance between the workers. Without this fix, some workers end up always updating their algo and trying to sample the next point but loose all race conditions. How: Use _trial_info to filter out duplicates while sampling points...
bouthilx
force-pushed
the
fix/balance_workload
branch
from
f3464bd to
fc9a477
Compare
Codecov Report
@@ Coverage Diff @@
## develop #361 +/- ##
===========================================
+ Coverage 45.54% 45.64% +0.09%
===========================================
Files 67 67
Lines 12192 12214 +22
Branches 316 317 +1
===========================================
+ Hits 5553 5575 +22
Misses 6614 6614
Partials 25 25
Continue to review full report at Codecov.
|
Delaunay
approved these changes
Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
The filtering of duplicates in RandomSearch is a lot more efficient than
relying on the database with DuplicateKeyErrors. There will still be
race conditions leading to this error, but filtering upfront in
RandomSearch reduces significantly the number of registration failures
and lead to better workload balance between the workers. Without this
fix, some workers end up always updating their algo and trying to sample
the next point but loose all race conditions.
How:
Use _trial_info to filter out duplicates while sampling points...