Dev/support entry point #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: The commandline parser is responsible of parsing the commandline (duh) and thus should also have the responsibility of inferring what the user script is in the given commandline. The repository check still remains in resolve_config as this is not specific to commandline parsing. This enables more complex parsing and reuse of templates to keep original positions in the commandline (previously it was assumed the script would be at first position in the commandline). How: Infer user script during parsing of commandline and save it as an attribute of the parser. The `user_args` now keeps the `user_script` within it, we can't simply pop out the first item anymore. The `user_script`, if found, is then used outside of the parser to detect a VCS.
Why: The modification to support more complex inference of user script fixed a bug that went unnoticed in the functional tests for branching. The modification of the user script name, which should be detected as a change in the commandline call, was not detected because it was popped out of `user_args`. With the modification it was not properly detected, making plenty of tests fail because they were unfortunately relying on the bug. How: Add --cli-change-type noeffect to let the EVC flow even though there are changes in the commandline calls (the bug was implicitly doing this). The test for --non-monitoring-arg was not suppose to lead to any version change, because the commandline should not be detected as different. Thus, in this case we remove --cli-change-type noeffect.
Support entry point from within OrionCmdlineParser
Add missing fix for func algo tests
Codecov Report
@@ Coverage Diff @@
## develop #333 +/- ##
==========================================
+ Coverage 41.19% 41.2% +0.01%
==========================================
Files 63 63
Lines 10820 10821 +1
Branches 271 271
==========================================
+ Hits 4457 4459 +2
+ Misses 6339 6338 -1
Partials 24 24
Continue to review full report at Codecov.
|
bouthilx
approved these changes
Feb 24, 2020
bouthilx
added a commit
to bouthilx/orion
that referenced
this pull request
Feb 25, 2020
PR Epistimio#333 adds support to entry points, removing the requirement to make scripts executable. This commit adapts to doc to this new feature.
bouthilx
added a commit
to bouthilx/orion
that referenced
this pull request
Feb 25, 2020
PR Epistimio#333 adds support to entry points, removing the requirement to make scripts executable. This commit adapts to doc to this new feature.
bouthilx
added a commit
to bouthilx/orion
that referenced
this pull request
Mar 6, 2020
PR Epistimio#333 adds support to entry points, removing the requirement to make scripts executable. This commit adapts to doc to this new feature.
Closed
bouthilx
added a commit
that referenced
this pull request
Jun 23, 2020
PR #333 adds support to entry points, removing the requirement to make scripts executable. This commit adapts to doc to this new feature.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.