Drop python3.5 support and add python3.8 #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delaunay
approved these changes
Oct 17, 2019
bouthilx
force-pushed
the
drop_3.5_add_3.8
branch
from
018216d to
6ae0bf8
Compare
|
Can't support py38 until this scipy/scipy#10930 gets released. |
Why: Python 3.8 was released a few days ago. For python 3.5, it lack of builtin ordered dictionary is growing cumbersome and likely not worth the hassle.
bouthilx
force-pushed
the
drop_3.5_add_3.8
branch
from
6ae0bf8 to
02a818d
Compare
|
Scipy support for py3.8 has been released 11 days ago https://github.com/scipy/scipy/releases/tag/v1.3.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
Python 3.8 was released a few days ago.
For python 3.5, it lack of builtin ordered dictionary is growing
cumbersome and likely not worth the hassle.