Adding Python API #300
Merged
Adding Python API #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bouthilx
force-pushed
the
feature/python_api
branch
2 times, most recently
from
51c2abf to
1c2d865
Compare
bouthilx
force-pushed
the
feature/python_api
branch
from
1cf4afd to
4604c3f
Compare
Why: The definition of the storage config was slightly different in some places and was also different that algo or database config.
Why: We need to fetch the metadata in `build()` in a manner that is agnostic to the API. The current implementation was expecting the commandline arguments as inputs. How: Function arguments are now user and user_args. If user_args are None, do nothing, else parse the commandline arguments to fetch script path and rest of arguments and save in metadata.
Why: Even when using the legacy backend, the Python API does not required using a file to pass the results.
Why: The python API gives the capacity to push results in storage. This should be only allowed if the trial is currently reserved by the current process.
Why: The interface of config and python API was incoherent, since the former required editing `producer.strategy` while the latter required editing `strategy` directly. To be coherent with other objects in configuration such as `algorthims` and `space`, we make `strategy` configurable at root.
bouthilx
force-pushed
the
feature/python_api
branch
from
b8b70a8 to
5a86d55
Compare
Delaunay
approved these changes
Oct 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.