Add orion db upgrade command
#293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bouthilx
force-pushed
the
feature/cli_upgrade
branch
from
c7d0ee7 to
7dff1ea
Compare
Why: There is breaking changes in the DB scheme (mostly importantly in the unique indexes definition). To fix this, we will provide a command to upgrade the db scheme explicitely (not implicitly during execution like we were first attempting). This will avoid breaking DBs and simplify the handling of backward compatibility in the db. How: - Add checks during DB creation to fail fast if the db is outdated and incompatible with current version - Add command `orion db upgrade` to fix the indexes and add missing fields (version, priors)
Why: `storage.fetch_experiments` returns documents, not `Experiment` objects. This makes it complicated to just fetch and update an experiment given that `update_experiment` expects an `Experiment` object.
bouthilx
force-pushed
the
feature/cli_upgrade
branch
from
7dff1ea to
1cecc30
Compare
Codecov Report
@@ Coverage Diff @@
## develop #293 +/- ##
===========================================
- Coverage 94.67% 94.58% -0.09%
===========================================
Files 62 62
Lines 9787 9813 +26
Branches 216 218 +2
===========================================
+ Hits 9266 9282 +16
- Misses 504 513 +9
- Partials 17 18 +1
Continue to review full report at Codecov.
|
Delaunay
approved these changes
Oct 9, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
There is breaking changes in the DB scheme (mostly importantly in the
unique indexes definition). To fix this, we will provide a command to
upgrade the db scheme explicitely (not implicitly during execution like
we were first attempting). This will avoid breaking DBs and simplify the
handling of backward compatibility in the db.
How:
incompatible with current version
orion db upgradeto fix the indexes and add missingfields (version, priors)