Fix deepcopy of Enumerate transform #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: The vectorized function of Enumerate could not be `deepcopy`ed making it unusable because of naive algorithm's that requires copying the original algo. How: Overwrite `__deepcopy__` the rebuild the Enumerate object instead of copying it.
bouthilx
force-pushed
the
hotfix/enumerate_deepcopy
branch
from
5eec7b0 to
9b9944f
Compare
Codecov Report
@@ Coverage Diff @@
## develop #290 +/- ##
===========================================
+ Coverage 93.34% 93.35% +0.01%
===========================================
Files 120 120
Lines 14788 14814 +26
Branches 1010 1010
===========================================
+ Hits 13804 13830 +26
Misses 882 882
Partials 102 102
Continue to review full report at Codecov.
|
Delaunay
approved these changes
Oct 6, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
The vectorized function of Enumerate could not be
deepcopyed making itunusable because of naive algorithm's that requires copying the original
algo.
How:
Overwrite
__deepcopy__the rebuild the Enumerate object instead ofcopying it.