Avoid branching in info
#277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bouthilx
added
bug
Delaunay
approved these changes
Aug 29, 2019
Why: When something is different in the environment, the experiment may branch since we are not using a `View` in `info`. We should rather use a view but for now they don't have access to instantiated space and algorithms which are required by `info`. How: Use a view and reconfigure it to instantiate the space and algo. This is not done by default in `View` because they crash if the users scripts in the experiment are not present on the current FS. At least now this only happens in `info`, which was already the case anyway since we were not using a `View`.
bouthilx
force-pushed
the
hotfix/info_branching
branch
from
88e7b02 to
45001ac
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
When something is different in the environment, the experiment may
branch since we are not using a
Viewininfo. We should rather use aview but for now they don't have access to instantiated space and
algorithms which are required by
info.How:
Use a view and reconfigure it to instantiate the space and algo. This is
not done by default in
Viewbecause they crash if the users scripts inthe experiment are not present on the current FS. At least now this only
happens in
info, which was already the case anyway since we were notusing a
View.