Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle status --name <exp> when empty #270

Merged
merged 1 commit into from
Aug 26, 2019

Conversation

bouthilx
Copy link
Member

Why:

The command would crash when no experiment matches the name passed with
--name.

Why:

The command would crash when no experiment matches the name passed with
--name.
@bouthilx bouthilx added bug Indicates an unexpected problem or unintended behavior v0.1.6 labels Aug 26, 2019
@bouthilx bouthilx requested a review from corneauf August 26, 2019 15:29
@codecov-io
Copy link

Codecov Report

Merging #270 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #270      +/-   ##
===========================================
+ Coverage    93.13%   93.13%   +<.01%     
===========================================
  Files          118      118              
  Lines        14009    14017       +8     
  Branches       961      962       +1     
===========================================
+ Hits         13047    13055       +8     
  Misses         869      869              
  Partials        93       93
Impacted Files Coverage Δ
tests/functional/commands/test_status_command.py 100% <100%> (ø) ⬆️
src/orion/core/cli/status.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19b33e1...4b41d1e. Read the comment docs.

@bouthilx bouthilx merged commit c631563 into Epistimio:develop Aug 26, 2019
@bouthilx
Copy link
Member Author

@bouthilx bouthilx mentioned this pull request Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants