Make ASHA opt out when last rungs are filled #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #267 +/- ##
===========================================
+ Coverage 93.18% 93.19% +<.01%
===========================================
Files 118 118
Lines 14136 14145 +9
Branches 972 975 +3
===========================================
+ Hits 13173 13182 +9
Misses 868 868
Partials 95 95
Continue to review full report at Codecov.
|
corneauf
approved these changes
Aug 26, 2019
Why: When running the trials in the last rungs, it takes a significant amount of time. During this time, all new trials in lower rungs won't be able to make up to top rungs, as the final rungs will get completed meanwhile. This results in significant waste of resources which could be freed and made available for others. How: When penultimate rung is filled, no more trials are promoted nor sampled at first level. This is because all trials required to select the final one are already available and no more computations are required beside completing the current trials in the penultimate rung.
bouthilx
force-pushed
the
feature/asha_opt_out
branch
from
21f9a39 to
a2c420e
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #266
Why:
When running the trials in the last rungs, it takes a significant amount
of time. During this time, all new trials in lower rungs won't be able
to make up to top rungs, as the final rungs will get completed
meanwhile. This results in significant waste of resources which could be
freed and made available for others.
How:
When penultimate rung is filled, no more trials are promoted nor sampled
at first level. This is because all trials required to select the final
one are already available and no more computations are required beside
completing the current trials in the penultimate rung.