Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove user as an index for Experiment #264

Merged
merged 3 commits into from
Aug 23, 2019

Conversation

corneauf
Copy link
Member

No description provided.

@corneauf corneauf requested a review from bouthilx August 20, 2019 20:55
@corneauf
Copy link
Member Author

@corneauf corneauf changed the base branch from master to develop August 21, 2019 19:32
Fix certain tests regarding users change

Change experiment.yaml and ajust some tests

The `supernaedo2` experiment has been "replaced" by the
`supernaedo2-dendi` as the mainly used experiment since the
hacked-exp fixture uses it. Therefore, most experiments in the yaml
file have been changed and tests inside `test_experiment` have been
adapted to reflect that change.

Fix tests for databases

Fix tests for producer

Fix tests for trials

Fix test for actual database

Fix tests for ExperimentBuilder

Fix tests for branching prompt
@codecov-io
Copy link

Codecov Report

Merging #264 into develop will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #264      +/-   ##
===========================================
- Coverage    93.15%   93.13%   -0.02%     
===========================================
  Files          118      118              
  Lines        14045    14009      -36     
  Branches       961      961              
===========================================
- Hits         13083    13047      -36     
  Misses         869      869              
  Partials        93       93
Impacted Files Coverage Δ
src/orion/storage/legacy.py 93.7% <ø> (ø) ⬆️
...sts/unittests/core/io/test_orion_cmdline_parser.py 99.14% <100%> (ø) ⬆️
tests/unittests/core/test_producer.py 100% <100%> (ø) ⬆️
src/orion/core/worker/experiment.py 90.22% <100%> (ø) ⬆️
tests/unittests/core/test_trial.py 100% <100%> (ø) ⬆️
tests/unittests/core/worker/test_experiment.py 96.85% <100%> (-0.18%) ⬇️
tests/unittests/core/test_ephemeraldb.py 100% <100%> (ø) ⬆️
tests/unittests/core/test_pickleddb.py 96.71% <100%> (ø) ⬆️
tests/unittests/core/io/test_experiment_builder.py 100% <100%> (ø) ⬆️
tests/unittests/core/conftest.py 90.07% <100%> (ø) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff4ea6a...23239b4. Read the comment docs.

@bouthilx bouthilx merged commit 19b33e1 into Epistimio:develop Aug 23, 2019
@bouthilx bouthilx mentioned this pull request Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants