Skip to content

[IMP] adding support for Arabic locales #2592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2022

Conversation

kerbrose
Copy link
Contributor

PRs relating to the v4 will be closed and locked.

  • Please check if the PR fulfills these requirements
  • [✓ ] The PR is against the development branch
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • [ ✓] Does NOT modify files under the "dist" folder.
  • What kind of change does this PR introduce?
    updates & improvements
    adding Arabic locale

  • What is the new behavior (if this is a feature change)?
    the arabic translation should appear correctly

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Eonasdan Eonasdan merged commit dfc9b2d into Eonasdan:development Jun 21, 2022
@Eonasdan
Copy link
Owner

Thank you for this. It will be published with the next release.

Eonasdan added a commit that referenced this pull request Jul 11, 2022
* make viewMode optional (#2551)

* introduce a simple overridable function parseInput (#2552)

so that you don't have to know all the internal details when overriding
this just gets 1 input and can return another
Just as formatInput also works (its the opposite)

* fixed #2487, #2495

* fixed #2487, #2495

* fix for #2506

* fix for #2549

* fix for #2549

* pub npm

* pub npm

* package update

* * added locale from pr
* updated github templates
* updated link nav

* fixes #2583, #2578

* [IMP] adding support for Arabic locales (#2592)

* Add display.theme option to control dark/light mode (#2593)

* adding display.theme to control dark vs light mode

* removing changes in dist folder per contribution guidelines

* fixes #2547

* upstream

* fixing bug where side-by-side shows blank clock (#2596) (#2597)

* fix clock

* fix #2595

* fix #2563
fix #2563

* fix #2599

* fix #2576

* issue templates to forms

* fixes #2568

* nuget package

* fix spelling and oops

* remove commented out code

Co-authored-by: Johan Compagner <[email protected]>
Co-authored-by: Khaled Said <[email protected]>
Co-authored-by: Killian Hale <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants