Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4: format LLLL not showing timepicker #740

Closed
bjoe2k4 opened this issue Jan 15, 2015 · 14 comments
Closed

v4: format LLLL not showing timepicker #740

bjoe2k4 opened this issue Jan 15, 2015 · 14 comments
Milestone

Comments

@bjoe2k4
Copy link

bjoe2k4 commented Jan 15, 2015

I am failing to get the timepicker to appear for formats LLLL or llll. It only works by using the full format 'dddd D MMMM YYYY LT'.

http://jsfiddle.net/0Ltv25o8/34/

@Eonasdan
Copy link
Owner

It looks like it's working for me

image

@Eonasdan Eonasdan reopened this Jan 15, 2015
@bjoe2k4
Copy link
Author

bjoe2k4 commented Jan 15, 2015

I don't get the timepicker for the first one.

http://jsfiddle.net/0Ltv25o8/35/
untitled

@Eonasdan
Copy link
Owner

ah quite right. I'll get it fixed

@Eonasdan
Copy link
Owner

mmm this might be a momentjs issue. It does the same thing for LLL. I've opened a new issue

@bjoe2k4
Copy link
Author

bjoe2k4 commented Jan 15, 2015

i not very confident they will fix this soon or even at all. In the meantime i would suggest to do the longdateFormat() simply twice.

http://jsfiddle.net/5Ld0ycLr/5/

@Eonasdan
Copy link
Owner

yup. If moment doesn't fix it, I'll just add a second longdate

@e2
Copy link

e2 commented Jan 26, 2015

👍

@kaworu
Copy link
Contributor

kaworu commented Jan 29, 2015

Hi,

I would be very pleased too by a fix / workaround for LLLL 👍

@Eonasdan
Copy link
Owner

@nikoskalogridis do you have any better idea's then what @bjoe2k4 has posted?

Eonasdan added a commit that referenced this issue Feb 3, 2015
Added temp fix for #740
Fixed: #726, #694
I think I fixed: #716
Features:
Added several key bindings from #693
Fully implemented inline mode! #381, #752, #692, #84
Added clear public function

had to revert namespace changes :(
@Eonasdan
Copy link
Owner

Eonasdan commented Feb 3, 2015

@bjoe2k4 added your fix to the dev branch until Moment address it (assuming they ever do)

@Eonasdan Eonasdan added this to the 4.3 milestone Feb 3, 2015
@bjoe2k4
Copy link
Author

bjoe2k4 commented Feb 3, 2015

Great, thanks!

@Eonasdan
Copy link
Owner

Eonasdan commented Mar 9, 2015

just to update this:

Moment acknowledged that this is an issue. It has been marked as a bug, but that's all

@kaworu
Copy link
Contributor

kaworu commented Mar 17, 2015

@Eonasdan thanks for the follow up 👍

@Eonasdan
Copy link
Owner

A fix in the momentjs library was merged to their dev branch! moment/moment#2419

v5 of the picker should be able to take out the double parse

@ghost ghost locked and limited conversation to collaborators Jun 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants