Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_dateToDataValue() should not use formatted month and date #2886

Closed
3 tasks done
hkvstore opened this issue Dec 18, 2023 · 1 comment · Fixed by #2887
Closed
3 tasks done

_dateToDataValue() should not use formatted month and date #2886

hkvstore opened this issue Dec 18, 2023 · 1 comment · Fixed by #2887

Comments

@hkvstore
Copy link
Contributor

Prerequisites

Describe the issue

Currently the code is:

  private _dateToDataValue(date: DateTime): string {
    if (!DateTime.isValid(date)) return '';

    return `${date.year}-${date.monthFormatted}-${date.dateFormatted}`;
  }

If Arabic locale is used, the outputted HTML will be like:
image

But the date value should not be formatted.

StackBlitz fork

https://stackblitz.com/edit/tempus-dominus-v6-simple-setup-hyrhpd?file=index.js

What operating system(s) are you seeing the problem on?

Windows

What browser(s) are you seeing the problem on?

Chrome

What version of are you using? You can find this information from the sample StackBlitz.

6.7.19

What your browser's locale? You can find this information from the sample StackBlitz.

en-US

@hkvstore hkvstore added State: Triage Tickets that need to be triaged. Type: Bug labels Dec 18, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in Tempus Dominus Dec 18, 2023
@Eonasdan Eonasdan added Area: TypeScript Area: Locale and removed Type: Bug State: Triage Tickets that need to be triaged. labels Dec 18, 2023
@Eonasdan Eonasdan moved this from 🆕 New to 🏗 In progress in Tempus Dominus Dec 18, 2023
@Eonasdan Eonasdan added the State: Pending Release This issue has been resolved in the dev branch and is waiting on a new release label Dec 20, 2023
Eonasdan added a commit that referenced this issue Dec 21, 2023
@Eonasdan Eonasdan mentioned this issue Dec 21, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Tempus Dominus Dec 21, 2023
Eonasdan added a commit that referenced this issue Dec 21, 2023
* fixes #2884

* fixes #2886

* fixes #2881

* fixes #2879

* fixes #2857

* #2793

* #2793
v6.9.4
@Eonasdan
Copy link
Owner

this is done in 6.9.4

@Eonasdan Eonasdan removed the State: Pending Release This issue has been resolved in the dev branch and is waiting on a new release label Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants