Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time picker disapear in side by side view #2684

Closed
3 tasks done
AlexandreMcCune opened this issue Oct 4, 2022 · 4 comments
Closed
3 tasks done

Time picker disapear in side by side view #2684

AlexandreMcCune opened this issue Oct 4, 2022 · 4 comments
Labels
Priority: Medium Type: Bug

Comments

@AlexandreMcCune
Copy link

AlexandreMcCune commented Oct 4, 2022 •
edited
Loading

Prerequisites

Describe the issue

With a side by side datetime picker, it is possible to make disapear the time picker.

Step-by-step to replicate the bug:

  • Open the datetime picker
  • Click on the hour or minute number
  • Click on the month or the arrows to change month.

At that point, the time picker disapear.

StackBlitz fork

https://stackblitz.com/edit/tempus-dominus-v6-simple-setup-pphjdf?embed=1&file=index.js

What operating system(s) are you seeing the problem on?

Windows

What browser(s) are you seeing the problem on?

Chrome, Firefox, Microsoft Edge

What version of are you using? You can find this information from the sample StackBlitz.

v6.2.4

What your browser's locale? You can find this information from the sample StackBlitz.

en-CA
@AlexandreMcCune AlexandreMcCune added State: Triage Tickets that need to be triaged. Type: Bug labels Oct 4, 2022
@Eonasdan Eonasdan added Priority: Medium and removed State: Triage Tickets that need to be triaged. labels Oct 24, 2022
@Eonasdan Eonasdan moved this to 🆕 New in Tempus Dominus Oct 24, 2022
@Eonasdan Eonasdan moved this from 🆕 New to 📋 Backlog in Tempus Dominus Oct 24, 2022
@Eonasdan Eonasdan moved this from 📋 Backlog to 🔖 Ready in Tempus Dominus Oct 27, 2022
@Eonasdan Eonasdan moved this from 🔖 Ready to 👀 In review in Tempus Dominus Oct 31, 2022
@Eonasdan Eonasdan moved this from 👀 In review to 🏗 In progress in Tempus Dominus Oct 31, 2022
Eonasdan added a commit that referenced this issue Nov 3, 2022
@Eonasdan
<h3>Bug fixes</h3>
ab2df0e 
      <ul>
        <li>Fixed calendar header not updating correctly #2685</li>
        <li>Fixed clock components disappearing when using side by side #2684</li>
      </ul>
Eonasdan added a commit that referenced this issue Nov 3, 2022
@Eonasdan
<h3>Bug fixes</h3>
fc2a949 
      <ul>
        <li>Fixed calendar header not updating correctly #2685</li>
        <li>Fixed clock components disappearing when using side by side #2684</li>
      </ul>
@Eonasdan
Copy link
Owner

Eonasdan commented Nov 3, 2022

Hi this should be fixed in the related branch, please check this stackblitz

@Eonasdan Eonasdan moved this from 🏗 In progress to 👀 In review in Tempus Dominus Nov 3, 2022
@cHamelCase
Copy link

Hi @Eonasdan, I work with @AlexandreMcCune, it looks like it works properly now, thanks!

@Eonasdan
Copy link
Owner

Eonasdan commented Nov 4, 2022

Great! Thanks for letting me know. I'll will include this in the next patch this weekend.

@Eonasdan Eonasdan moved this from 👀 In review to ✅ Done in Tempus Dominus Nov 4, 2022
This was referenced Nov 5, 2022
Closed
Merged
Eonasdan added a commit that referenced this issue Nov 5, 2022
@Eonasdan
Master 627 (#2714)
5e04fcc 
<h2>6.2.7</h2>
      <h3>Bug fixes</h3>
      <ul>
        <li>Fixed customDateFormat shows 'undefined' when you manually erase the date #2693</li>
        <li>Fixed calendar header not updating correctly #2685</li>
        <li>Fixed clock components disappearing when using side by side #2684</li>
        <li>Fixed some doc issues #2706</li>
      </ul>
      <h3>New</h3>
      <ul>
        <li>Unit tests! #2711</li>
    </ul>
@Eonasdan
Copy link
Owner

Eonasdan commented Nov 5, 2022

Hello. This should be fixed in 6.2.7

@Eonasdan Eonasdan closed this as completed Nov 5, 2022
@Eonasdan Eonasdan moved this from ✅ Done to 🚀 Released in Tempus Dominus Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: Medium Type: Bug
Projects
Tempus Dominus
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Eonasdan @cHamelCase @AlexandreMcCune