Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox crashed when date is selected #117

Closed
leebake opened this issue Jan 7, 2014 · 10 comments
Closed

Firefox crashed when date is selected #117

leebake opened this issue Jan 7, 2014 · 10 comments
Milestone

Comments

@leebake
Copy link

leebake commented Jan 7, 2014

In the latest version when you select a date, the script hangs and browser closes. Tested with Firefox 26.0, jQuery 2.0.3 http://code.jquery.com/jquery-2.0.3.min.js, moment 2.5.0 http://momentjs.com/downloads/moment.min.js and latest version of datetimepicker https://raw.github.com/Eonasdan/bootstrap-datetimepicker/master/src/js/bootstrap-datetimepicker.js

@billsuxx
Copy link

billsuxx commented Jan 7, 2014

I have similar problem, but as i see it crash only when the selector is on the input. (example: http://eonasdan.github.io/bootstrap-datetimepicker/#example6)

@Eonasdan
Copy link
Owner

Eonasdan commented Jan 7, 2014

This seems to be a continuing issue from trying to get the native jquery change event to fire. Commenting out line 270 and 271 seems to resolve the issue

@kryten87
Copy link

kryten87 commented Jan 7, 2014

Same thing happens in Google Chrome.

The problem appears to be that it goes into an infinite loop (or at least until the browser runs out of resources).

Changing line 270 from

if (eventType !== 'change')

to

if (eventType == 'click')

partially solves the problem. The update works when clicking on the calendar but does not work when the date is typed into the input element.

@Eonasdan
Copy link
Owner

Eonasdan commented Jan 7, 2014

For the time being, I've commented out those lines again. I hope that we can get something working right for those of you using knockout

@AdnanZi
Copy link

AdnanZi commented Jan 8, 2014

Please see my comment on the issue #83. The commented lines are not the issue, but the issue is event type argument missing from notifiyChange call on 'change' method.

Pull request #118 should resolve all of these.

@leebake
Copy link
Author

leebake commented Jan 9, 2014

Can you update version for Bower because when I update it by bower changes are not visible. Current version downloaded by bower has taken this bug.

@polastre
Copy link

#119 is probably related (or the same).

@Eonasdan
Copy link
Owner

please check that latest version. I believe this issue has been fix

@Eonasdan
Copy link
Owner

Check out the staging branch.

Please let me know if your issue has been resolved.

@leebake
Copy link
Author

leebake commented Jan 24, 2014

Yes, in staging branch everything works fine

Eonasdan added a commit that referenced this issue Jan 25, 2014
Important! build.less file name has been been changed to
bootstrap-datetimepicker-build.less to prevent collisions

Fix for #135: setStartDate and setEndDate should now properly set.
Fix for #133: Typed in date now respects en/disabled dates
Fix for #132: En/disable picker function works again
Fix for #117, #119, #128, #121: double event change event issues should
be fixed
Fix for #112: change function no longer sets the input to a blank value
if the passed in date is invalid

Enhancement for #103: Increated the z-index of the widget
@ghost ghost locked and limited conversation to collaborators Jun 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants