-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ensure size of value in setproperty is same as original shape #162
Open
avik-pal
wants to merge
1
commit into
main
Choose a base branch
from
ap/safe_getprop
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avik-pal
force-pushed
the
ap/safe_getprop
branch
from
October 4, 2024 17:45
2538573
to
f893df2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reactant.jl Benchmarks
Benchmark suite | Current: f893df2 | Previous: deefd18 | Ratio |
---|---|---|---|
ViT base (256 x 256 x 3 x 32)/forward/CUDA/Reactant |
1306561429 ns |
1354313354 ns |
0.96 |
ViT base (256 x 256 x 3 x 32)/forward/CUDA/Lux |
213416006 ns |
208305734 ns |
1.02 |
ViT base (256 x 256 x 3 x 32)/forward/CPU/Reactant |
6931763831 ns |
5150619393 ns |
1.35 |
ViT base (256 x 256 x 3 x 32)/forward/CPU/Lux |
17490173184 ns |
19034043181 ns |
0.92 |
ViT small (256 x 256 x 3 x 4)/forward/CUDA/Reactant |
1246646310.5 ns |
1337880973 ns |
0.93 |
ViT small (256 x 256 x 3 x 4)/forward/CUDA/Lux |
8460235 ns |
9140912.5 ns |
0.93 |
ViT small (256 x 256 x 3 x 4)/forward/CPU/Reactant |
1675295978 ns |
1693455123 ns |
0.99 |
ViT small (256 x 256 x 3 x 4)/forward/CPU/Lux |
2521781598 ns |
2263974104 ns |
1.11 |
ViT tiny (256 x 256 x 3 x 32)/forward/CUDA/Reactant |
1269767952.5 ns |
1332284786.5 ns |
0.95 |
ViT tiny (256 x 256 x 3 x 32)/forward/CUDA/Lux |
87409691 ns |
86734383.5 ns |
1.01 |
ViT tiny (256 x 256 x 3 x 32)/forward/CPU/Reactant |
2280190510 ns |
2287781106 ns |
1.00 |
ViT tiny (256 x 256 x 3 x 32)/forward/CPU/Lux |
4645118034 ns |
6118937863 ns |
0.76 |
ViT tiny (256 x 256 x 3 x 4)/forward/CUDA/Reactant |
1276716567 ns |
1274319613 ns |
1.00 |
ViT tiny (256 x 256 x 3 x 4)/forward/CUDA/Lux |
7637342 ns |
7577830 ns |
1.01 |
ViT tiny (256 x 256 x 3 x 4)/forward/CPU/Reactant |
1510690537 ns |
1512493678 ns |
1.00 |
ViT tiny (256 x 256 x 3 x 4)/forward/CPU/Lux |
1340018711 ns |
1456174515 ns |
0.92 |
ViT tiny (256 x 256 x 3 x 16)/forward/CUDA/Reactant |
1323229326.5 ns |
1263335461 ns |
1.05 |
ViT tiny (256 x 256 x 3 x 16)/forward/CUDA/Lux |
11596388.5 ns |
11439682 ns |
1.01 |
ViT tiny (256 x 256 x 3 x 16)/forward/CPU/Reactant |
1800478449 ns |
1805020552 ns |
1.00 |
ViT tiny (256 x 256 x 3 x 16)/forward/CPU/Lux |
2783250001 ns |
2506386037 ns |
1.11 |
ViT small (256 x 256 x 3 x 16)/forward/CUDA/Reactant |
1296581712 ns |
1307096998 ns |
0.99 |
ViT small (256 x 256 x 3 x 16)/forward/CUDA/Lux |
95258089 ns |
87573137 ns |
1.09 |
ViT small (256 x 256 x 3 x 16)/forward/CPU/Reactant |
2268870487 ns |
2278669956 ns |
1.00 |
ViT small (256 x 256 x 3 x 16)/forward/CPU/Lux |
3997383112 ns |
3700585497 ns |
1.08 |
ViT small (256 x 256 x 3 x 32)/forward/CUDA/Reactant |
1312074673.5 ns |
1310298018 ns |
1.00 |
ViT small (256 x 256 x 3 x 32)/forward/CUDA/Lux |
116467429.5 ns |
109805738 ns |
1.06 |
ViT small (256 x 256 x 3 x 32)/forward/CPU/Reactant |
3088491410 ns |
3158445388 ns |
0.98 |
ViT small (256 x 256 x 3 x 32)/forward/CPU/Lux |
11196658303 ns |
14341152106 ns |
0.78 |
ViT base (256 x 256 x 3 x 16)/forward/CUDA/Reactant |
1344423772 ns |
1384173668 ns |
0.97 |
ViT base (256 x 256 x 3 x 16)/forward/CUDA/Lux |
132933129 ns |
125016343 ns |
1.06 |
ViT base (256 x 256 x 3 x 16)/forward/CPU/Reactant |
3308979469 ns |
3254191833 ns |
1.02 |
ViT base (256 x 256 x 3 x 16)/forward/CPU/Lux |
6507271413 ns |
6513914428 ns |
1.00 |
ViT base (256 x 256 x 3 x 4)/forward/CUDA/Reactant |
1304485316.5 ns |
1339992292 ns |
0.97 |
ViT base (256 x 256 x 3 x 4)/forward/CUDA/Lux |
87668820.5 ns |
81713817 ns |
1.07 |
ViT base (256 x 256 x 3 x 4)/forward/CPU/Reactant |
2057165270 ns |
1963454757 ns |
1.05 |
ViT base (256 x 256 x 3 x 4)/forward/CPU/Lux |
2481863016 ns |
2503177627 ns |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.