Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ensure size of value in setproperty is same as original shape #162

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

avik-pal
Copy link
Collaborator

@avik-pal avik-pal commented Oct 4, 2024

No description provided.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reactant.jl Benchmarks

Benchmark suite Current: f893df2 Previous: deefd18 Ratio
ViT base (256 x 256 x 3 x 32)/forward/CUDA/Reactant 1306561429 ns 1354313354 ns 0.96
ViT base (256 x 256 x 3 x 32)/forward/CUDA/Lux 213416006 ns 208305734 ns 1.02
ViT base (256 x 256 x 3 x 32)/forward/CPU/Reactant 6931763831 ns 5150619393 ns 1.35
ViT base (256 x 256 x 3 x 32)/forward/CPU/Lux 17490173184 ns 19034043181 ns 0.92
ViT small (256 x 256 x 3 x 4)/forward/CUDA/Reactant 1246646310.5 ns 1337880973 ns 0.93
ViT small (256 x 256 x 3 x 4)/forward/CUDA/Lux 8460235 ns 9140912.5 ns 0.93
ViT small (256 x 256 x 3 x 4)/forward/CPU/Reactant 1675295978 ns 1693455123 ns 0.99
ViT small (256 x 256 x 3 x 4)/forward/CPU/Lux 2521781598 ns 2263974104 ns 1.11
ViT tiny (256 x 256 x 3 x 32)/forward/CUDA/Reactant 1269767952.5 ns 1332284786.5 ns 0.95
ViT tiny (256 x 256 x 3 x 32)/forward/CUDA/Lux 87409691 ns 86734383.5 ns 1.01
ViT tiny (256 x 256 x 3 x 32)/forward/CPU/Reactant 2280190510 ns 2287781106 ns 1.00
ViT tiny (256 x 256 x 3 x 32)/forward/CPU/Lux 4645118034 ns 6118937863 ns 0.76
ViT tiny (256 x 256 x 3 x 4)/forward/CUDA/Reactant 1276716567 ns 1274319613 ns 1.00
ViT tiny (256 x 256 x 3 x 4)/forward/CUDA/Lux 7637342 ns 7577830 ns 1.01
ViT tiny (256 x 256 x 3 x 4)/forward/CPU/Reactant 1510690537 ns 1512493678 ns 1.00
ViT tiny (256 x 256 x 3 x 4)/forward/CPU/Lux 1340018711 ns 1456174515 ns 0.92
ViT tiny (256 x 256 x 3 x 16)/forward/CUDA/Reactant 1323229326.5 ns 1263335461 ns 1.05
ViT tiny (256 x 256 x 3 x 16)/forward/CUDA/Lux 11596388.5 ns 11439682 ns 1.01
ViT tiny (256 x 256 x 3 x 16)/forward/CPU/Reactant 1800478449 ns 1805020552 ns 1.00
ViT tiny (256 x 256 x 3 x 16)/forward/CPU/Lux 2783250001 ns 2506386037 ns 1.11
ViT small (256 x 256 x 3 x 16)/forward/CUDA/Reactant 1296581712 ns 1307096998 ns 0.99
ViT small (256 x 256 x 3 x 16)/forward/CUDA/Lux 95258089 ns 87573137 ns 1.09
ViT small (256 x 256 x 3 x 16)/forward/CPU/Reactant 2268870487 ns 2278669956 ns 1.00
ViT small (256 x 256 x 3 x 16)/forward/CPU/Lux 3997383112 ns 3700585497 ns 1.08
ViT small (256 x 256 x 3 x 32)/forward/CUDA/Reactant 1312074673.5 ns 1310298018 ns 1.00
ViT small (256 x 256 x 3 x 32)/forward/CUDA/Lux 116467429.5 ns 109805738 ns 1.06
ViT small (256 x 256 x 3 x 32)/forward/CPU/Reactant 3088491410 ns 3158445388 ns 0.98
ViT small (256 x 256 x 3 x 32)/forward/CPU/Lux 11196658303 ns 14341152106 ns 0.78
ViT base (256 x 256 x 3 x 16)/forward/CUDA/Reactant 1344423772 ns 1384173668 ns 0.97
ViT base (256 x 256 x 3 x 16)/forward/CUDA/Lux 132933129 ns 125016343 ns 1.06
ViT base (256 x 256 x 3 x 16)/forward/CPU/Reactant 3308979469 ns 3254191833 ns 1.02
ViT base (256 x 256 x 3 x 16)/forward/CPU/Lux 6507271413 ns 6513914428 ns 1.00
ViT base (256 x 256 x 3 x 4)/forward/CUDA/Reactant 1304485316.5 ns 1339992292 ns 0.97
ViT base (256 x 256 x 3 x 4)/forward/CUDA/Lux 87668820.5 ns 81713817 ns 1.07
ViT base (256 x 256 x 3 x 4)/forward/CPU/Reactant 2057165270 ns 1963454757 ns 1.05
ViT base (256 x 256 x 3 x 4)/forward/CPU/Lux 2481863016 ns 2503177627 ns 0.99

This comment was automatically generated by workflow using github-action-benchmark.

Copy link
Contributor

github-actions bot commented Oct 4, 2024

Benchmark Results

main f893df2... main/f893df2ed8a43e...
comptime/basics/2D sum 27 ± 1.1 ms 27.4 ± 1.2 ms 0.983
comptime/basics/Basic grad cos 0.0464 ± 0.00089 s 0.0453 ± 0.00087 s 1.02
comptime/basics/cos.(x) 0.0321 ± 0.0012 s 0.032 ± 0.0014 s 1
comptime/lux neural networks/ViT base 5.68 s 5.72 s 0.992
comptime/lux neural networks/ViT tiny 5.72 s 5.72 s 1
comptime/lux neural networks/vgg11 bn=false 0.387 ± 0.013 s 0.384 ± 0.015 s 1.01
comptime/lux neural networks/vgg13 bn=false 0.441 ± 0.01 s 0.445 ± 0.016 s 0.993
comptime/lux neural networks/vgg16 bn=false 0.546 ± 0.0065 s 0.524 ± 0.029 s 1.04
comptime/lux neural networks/vgg19 bn=false 0.589 ± 0.0089 s 0.597 ± 0.0065 s 0.986
runtime/lux neural networks/ViT base (compiled) 6.42 s 6.39 s 1
runtime/lux neural networks/ViT tiny (compiled) 1.76 s 1.68 s 1.05
runtime/lux neural networks/vgg11 bn=false (compiled) 2.11 s 2.12 s 0.996
runtime/lux neural networks/vgg13 bn=false (compiled) 3 s 3.02 s 0.995
runtime/lux neural networks/vgg16 bn=false (compiled) 3.75 s 3.76 s 0.995
runtime/lux neural networks/vgg19 bn=false (compiled) 4.59 s 4.59 s 1
time_to_load 1.48 ± 0.0055 s 1.5 ± 0.016 s 0.986

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant