Update to ParallelTestRunner v2 - #2690
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2690 +/- ##
==========================================
- Coverage 72.58% 72.57% -0.02%
==========================================
Files 58 58
Lines 18739 18739
==========================================
- Hits 13602 13600 -2
- Misses 5137 5139 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8914dc3 to
771637c
Compare
giordano
changed the title
There was a problem hiding this comment.
@icweaver I feel like you may be interested in the changes in this file: you can easily run tests in verbose mode in CI with
- uses: julia-actions/julia-runtest@v1
with:
test_args: '--verbose'The other changes in this PR are for using multiple jobs on macOS (we need to see if we have enough memory for running them though)
giordano
left a comment
giordano
left a comment
There was a problem hiding this comment.
@vchuravy now that the threads.jl testset is run directly, instead of through multi-threads.jl, there's no clear indication of how many threads are run. Only hint is the messed up printing:
Output generated during execution of 'threads/2':
┌ The number of this iteration is 11
│ The number of this iteration is 16
│ The number of this iteration is 1
│ The number of this iteration is 6
│ The number of this iteration is 1
│ The number of this iteration is 11
│ The number of this iteration is 16
└ The number of this iteration is 6
Maybe that's not a big deal and we simply trust that the tests are configured correctly?
One the bright side, using multiple macOS jobs brought some nice speedup:
- on
main:Julia 1.10 - macOS-latest - default - local libEnzyme - assertions=false: 20m36.4sJulia 1.10 - macOS-latest - default - packaged libEnzyme - assertions=false: 15m58.3sJulia 1.11 - macOS-latest - default - local libEnzyme - assertions=false: 45m21.4sJulia 1.11 - macOS-latest - default - packaged libEnzyme - assertions=false: 34m47.5s
- this PR:
Julia 1.10 - macOS-latest - default - local libEnzyme - assertions=false: 10m50.5sJulia 1.10 - macOS-latest - default - packaged libEnzyme - assertions=false: 10m00.1sJulia 1.11 - macOS-latest - default - local libEnzyme - assertions=false: 30m24.1sJulia 1.11 - macOS-latest - default - packaged libEnzyme - assertions=false: 20m52.7s
771637c to
7d8562d
Compare
|
|
||
| if filter_tests!(testsuite, args) | ||
| # Skip GPU-specific tests by default. | ||
| delete!(testsuite, "metal") |
There was a problem hiding this comment.
we're running these at least in gpu ci right?
There was a problem hiding this comment.
This was skipped already before.
There was a problem hiding this comment.
As far as I understand, the CUDA one is run at
Enzyme.jl/.buildkite/pipeline.yml
Line 25 in 2cd186b
| using ParallelTestRunner: addworker, filter_tests!, find_tests, parse_args, runtests | ||
|
|
||
| function test_filter(test) | ||
| if test ∈ ("metal", "cuda", "amdgpu") |
4 participants
No description provided.