fix(e2e): stop asserting current_task on public workspace GET - #984
Merged
Merged
Conversation
PR #966 intentionally stripped current_task, last_sample_error, and workspace_dir from the public GET /workspaces/:id response to avoid leaking task bodies to anyone with a workspace bearer. The E2E smoke test hadn't caught up — it was still asserting "current_task":"..." on the single-workspace GET, which made every post-#966 CI run fail with '60 passed, 2 failed'. Swap the per-workspace asserts to check active_tasks (still exposed, canonical busy signal) and keep the list-endpoint check that proves admin-auth'd callers still see current_task end-to-end. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
molecule-ai Bot
pushed a commit
that referenced
this pull request
Apr 21, 2026
fix(e2e): stop asserting current_task on public workspace GET
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #966 stripped `current_task`, `last_sample_error`, and `workspace_dir` from the public `GET /workspaces/:id` response (security fix — those fields leak task bodies / agent errors / host paths to any workspace-bearer holder). The E2E smoke test kept asserting `"current_task":"Analyzing document"` on the single-workspace GET, so every post-#966 CI run has failed with `60 passed, 2 failed`.
Swap the per-workspace asserts to `active_tasks` (still exposed, canonical busy signal) and keep the list-endpoint check that proves admin-auth'd callers still see `current_task` end-to-end.
Blocks
Staging → main promotion (#983 — this test drift is the only red on the promotion PR).
🤖 Generated with Claude Code