fix: add main landmark, skip link, and aria-label to canvas (WCAG 2.4.1/2.4.6) - #32
Merged
Merged
Conversation
….1/2.4.6) - Wrap CanvasInner return in React Fragment to host skip-nav link as sibling of <main> - Add <a href="#canvas-main"> skip link (sr-only, revealed on focus) before <main> - Add id="canvas-main" to <main> element - Add aria-label="Molecule AI workspace canvas" to ReactFlow wrapper - Add Canvas.a11y.test.tsx: 4 jsdom tests covering all three a11y landmarks 369/369 tests pass; next build clean. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
|
7-gate verification passed:
Skip link hidden by default, visible only on keyboard focus (verified via screenshot). WCAG 2.4.1 bypass-blocks and 2.4.6 headings-labels satisfied via + aria-label on ReactFlow.Merging. |
HongmingWang-Rabbit
pushed a commit
that referenced
this pull request
Apr 14, 2026
Adds a `canvas-deploy-reminder` job to ci.yml that fires on every push to main once `canvas-build` passes. It posts a commit comment via the built-in GITHUB_TOKEN (no new secrets needed) reminding whoever monitors CI to run: cd /g/personal_programs/molecule-monorepo git pull origin main docker compose build canvas && docker compose up -d canvas The comment includes the commit SHA and a direct link to the build log. Rationale: 5 consecutive merge cycles (PRs #21, #25, #30, #32, #34) went undeployed because there is no auto-deploy hook and the manual step was silently forgotten. A commit comment on the merge commit is the lowest-friction reminder that requires no external secrets or infra. Does NOT run on PRs — only on direct pushes to main (i.e. post-merge). Uses `needs: canvas-build` so the reminder only fires after build+tests pass; a failing build produces no comment. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This was referenced Apr 14, 2026
molecule-ai Bot
pushed a commit
that referenced
this pull request
Apr 21, 2026
fix: add main landmark, skip link, and aria-label to canvas (WCAG 2.4.1/2.4.6)
molecule-ai Bot
pushed a commit
that referenced
this pull request
Apr 21, 2026
Adds a `canvas-deploy-reminder` job to ci.yml that fires on every push to main once `canvas-build` passes. It posts a commit comment via the built-in GITHUB_TOKEN (no new secrets needed) reminding whoever monitors CI to run: cd /g/personal_programs/molecule-monorepo git pull origin main docker compose build canvas && docker compose up -d canvas The comment includes the commit SHA and a direct link to the build log. Rationale: 5 consecutive merge cycles (PRs #21, #25, #30, #32, #34) went undeployed because there is no auto-deploy hook and the manual step was silently forgotten. A commit comment on the merge commit is the lowest-friction reminder that requires no external secrets or infra. Does NOT run on PRs — only on direct pushes to main (i.e. post-merge). Uses `needs: canvas-build` so the reminder only fires after build+tests pass; a failing build produces no comment. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This was referenced Apr 24, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CanvasInnerreturn in a React Fragment so a skip-nav<a>can live as a DOM sibling before<main>(no wrapping div added)<a href="#canvas-main">Skip to canvas</a>—sr-onlynormally, revealed on keyboard focus — satisfying WCAG 2.4.1 bypass blocksid="canvas-main"to the<main>element so the skip link target is validaria-label="Molecule AI workspace canvas"to theReactFlowwrapper for WCAG 2.4.6 descriptive labelsTest plan
Canvas.a11y.test.tsx— 4 new jsdom tests:<main>landmark presence, skip link href/text, ReactFlow aria-label, DOM order (skip before main viacompareDocumentPosition)npm run buildclean — no TypeScript errors, no Next.js warningsFiles changed
canvas/src/components/Canvas.tsx— 3 surgical edits (Fragment wrapper, skip link,id="canvas-main",aria-labelprop)canvas/src/components/__tests__/Canvas.a11y.test.tsx— new 139-line test file🤖 Generated with Claude Code