test(e2e): pin pick_model_slug behavior with bash unit tests - #2619
Merged
Merged
Conversation
PR #2571 fixed synth-E2E by branching MODEL_SLUG per runtime, but only the langgraph branch was verified at runtime — hermes / claude-code / override / fallback had zero automated coverage. A future regression (e.g. dropping the langgraph case) would silently revert and only surface as "Could not resolve authentication method" mid-E2E. This PR: - Extracts the dispatch into tests/e2e/lib/model_slug.sh as a sourceable pick_model_slug() function. No behavior change. - Adds tests/e2e/test_model_slug.sh — 9 assertions across all 5 dispatch branches plus the override path. Verified to FAIL when any branch is flipped (manually regressed langgraph slash-form to confirm the test catches it; restored before commit). - Wires the unit test into ci.yml's existing shellcheck job (only runs when tests/e2e/ or scripts/ change). Pure-bash, no live infra. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
HongmingWang-Rabbit
requested a review
from hongmingwang-moleculeai
as a code owner
May 3, 2026 19:04
HongmingWang-Rabbit
enabled auto-merge
May 3, 2026 19:04
HongmingWang-Rabbit
pushed a commit
that referenced
this pull request
Jun 12, 2026
…context-exists-in-bp) The new e2e-staging-workspace-requests job emits a status context the Tier-2g lint requires to be acknowledged. It's additive (not branch- protection-required), same as the concierge e2e job — '# bp-required: pending #2619' (the e2e-gating umbrella tracks whether these become required). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #2571 review follow-up. The runtime-aware MODEL_SLUG dispatch had only one of five branches exercised by automation (langgraph, via the synth-E2E happy path). A future regression dropping or flipping any other branch would silently revert and only surface as "Could not resolve authentication method" mid-E2E.
Change
Test discriminators (per feedback_assert_exact_not_substring memory)
Manually regressed langgraph slash-form locally → test caught it (2 failures, exit 1). Restored → all 9 pass. The test pins behavior, not just exit-zero.
Coverage delta
Test plan
🤖 Generated with Claude Code