ci(redeploy): fix stale canary_slug default 'hongmingwang' → 'hongming' - #2569
Merged
Conversation
The workflow_dispatch input default and the workflow_run env fallback both pointed at 'hongmingwang', which doesn't match any current prod tenant (slugs are: hongming, chloe-dong, reno-stars). CP silently skipped the missing canary and put every tenant in batch-1 in parallel, defeating the canary-first soak gate that exists to catch image-boot regressions before they hit the whole fleet. Concrete example from today's c0838d6 redeploy at 11:53Z (run 25278434388): the dispatched body was `{"target_tag":"staging-c0838d6","canary_slug":"hongmingwang",...}` and the CP response showed all 3 tenants in `"phase":"batch-1"` — no soak, no canary. The deploy happened to be safe, but a broken image would have hit hongming + chloe-dong + reno-stars simultaneously. Fixed in three places: the runtime ordering comment, the workflow_dispatch default, and the env fallback used by the workflow_run trigger. Comment documents the rationale so the next slug rename doesn't silently regress this again. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
HongmingWang-Rabbit
requested a review
from hongmingwang-moleculeai
as a code owner
May 3, 2026 12:06
HongmingWang-Rabbit
enabled auto-merge
May 3, 2026 12:06
HongmingWang-Rabbit
pushed a commit
that referenced
this pull request
Jun 12, 2026
chore(ci): remove dead arm64-darwin self-hosted lanes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
redeploy-tenants-on-main.ymlworkflow_dispatch input default and the workflow_run env fallback both pointed athongmingwang, which doesn't match any current prod tenant (real slugs arehongming,chloe-dong,reno-stars). CP silently skipped the missing canary and put every tenant in batch-1 in parallel, defeating the canary-first soak gate.Concrete example
Today's c0838d6 redeploy at 11:53Z (run 25278434388):
{"target_tag":"staging-c0838d6","canary_slug":"hongmingwang","soak_seconds":60,"batch_size":3,"dry_run":false}"phase":"batch-1"— nocanaryphase, no soak.The deploy happened to be safe (canvas warm-paper React Flow
colorModefix). But a broken image would have hit hongming + chloe-dong + reno-stars simultaneously instead of failing on hongming alone after a 60s soak.Changes
Three sites in
.github/workflows/redeploy-tenants-on-main.yml:workflow_dispatch.inputs.canary_slug.default(line 59)env.CANARY_SLUGfallback used by theworkflow_runtrigger (line 151)Added an inline comment documenting the rationale so the next slug rename doesn't silently regress this again.
Test plan
"phase":"canary"for hongming, then"batch-1"for chloe-dong + reno-stars after the 60s soak