docs(a2a): correct misleading v1-tolerance comments - #2514
Merged
Conversation
Follow-up to PR #2509/#2510. The defensive v1-detection branches in extract_attached_files (Python) and extractFilesFromTask (TypeScript) were merged with comments claiming they fix a "v0→v1 silent-drop" bug that surfaced as the 2026-05-01 hongming "no text content" incident. Live test disproved that hypothesis: a2a-sdk's JSON-RPC layer validates inbound requests against the v0 Pydantic union, so v1 shapes are rejected at the request boundary — the v1 detection branch is unreachable on the JSON-RPC ingress path. The actual root cause of the hongming incident was the missing /workspace chown fixed by CP PR #381 + test #382. Update the comments to honestly describe these branches as defensive future-proofing (kept against an eventual SDK schema migration or in-process callers that construct Parts directly from protobuf), not as fixes for an observed bug. Also trims ChatTab.tsx's outbound-shape comment block from ~21 lines to a 3-line pointer to the SDK union. Comment-only change. No behavior change. 86 workspace tests + 91 canvas tests still pass.
HongmingWang-Rabbit
requested a review
from hongmingwang-moleculeai
as a code owner
May 2, 2026 09:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to PR #2509 + PR #2510. The defensive v1-detection branches that survived the revert had comments claiming they fix a "v0→v1 silent-drop" bug — the 2026-05-01 hongming "no text content" incident. Live test against the (chown-fixed) hongming workspace disproved that hypothesis:
The actual root cause of the hongming incident was the missing `/workspace` chown — fixed by CP PR #381 (cloud-init mkdir+chown) + test pin #382 (task #230, both already shipped).
Scope
Comment-only. The defensive v1 branches stay; their docstrings now honestly describe them as future-proofing against:
Also trims `ChatTab.tsx`'s outbound-shape comment from ~21 lines to a 3-line pointer to the SDK union.
Test plan
Why a follow-up PR rather than amending PR #2509
PR #2509 + PR #2510 both already merged. The misleading comments don't break anything operationally — this is a code-review finding (correctness of stated rationale), not a bug. Documenting the corrected understanding in commit history is the right shape.