chore(gitattributes): pin LF on snapshot golden files - #2260
Merged
Merged
Conversation
Self-review follow-up on #2258 (registry snapshot tests, just merged). The byte-exact snapshot comparisons in test_platform_tools.py would fail mysteriously on a Windows contributor's machine with core.autocrlf=true: checkout would convert LF → CRLF, the test would fail locally with no useful diagnostic, and the regen instructions in the test-file header would produce LF files that disagree with the working copy. Pin workspace/tests/snapshots/*.txt to text eol=lf so this can't happen. All three current snapshots are already LF; the attribute ensures it stays that way. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
HongmingWang-Rabbit
requested a review
from hongmingwang-moleculeai
as a code owner
April 29, 2026 04:01
2 tasks
HongmingWang-Rabbit
pushed a commit
that referenced
this pull request
Apr 29, 2026
Two docs covering load-bearing patterns from today's work that weren't previously discoverable: 1. workspace/platform_tools/README.md — explains the ToolSpec single-source-of-truth pattern (#2240), the CLI-block alignment gap that hand-maintained generation can't close (#2258), the snapshot golden files + LF-pinning (#2260), and the add/rename/ remove playbook. The next reader who lands in workspace/platform_tools/ now has the design rationale + the safe-edit procedure colocated with the code. 2. scripts/README.md — disambiguates the three measure-coordinator- task-bounds.sh files that now exist across two repos: - scripts/measure-coordinator-task-bounds.sh (canonical OSS, this repo) - scripts/measure-coordinator-task-bounds-runner.sh (Hermes/MiniMax variant, this repo) - scripts/measure-coordinator-task-bounds.sh (production-shape, in molecule-controlplane) Cross-references reference_harness_pair_pattern (auto-memory) for the cross-repo design rationale. Documents the common safety pattern (cleanup trap, DRY_RUN, non-target guard, cleanup_*_failed events) and the heartbeat-trace caveat. Refs: #2240, #2254, #2257, #2258, #2259, #2260; molecule-controlplane#321. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
HongmingWang-Rabbit
pushed a commit
that referenced
this pull request
Jun 12, 2026
…wup) PR #2260's contract tests were written against the old v0.2 shape ("type": "text") but main was already fixed to use v0.3's "kind" discriminator. Update both delegation_test.go and mcp_test.go to assert "kind" instead of "type". Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
HongmingWang-Rabbit
pushed a commit
that referenced
this pull request
Jun 12, 2026
Serialized merge by gitea-merge-queue after current-main, genuine approvals, and required CI checks were green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Self-review follow-up on #2258 (just merged).
The byte-exact snapshot comparisons in
test_platform_tools.pywould fail mysteriously on a Windows contributor's machine withcore.autocrlf=true— checkout would convert LF → CRLF, the test would fail locally with no useful diagnostic, and the regen instructions in the test-file header would produce LF files that disagree with the working-copy CRLF versions.Pin
workspace/tests/snapshots/*.txttotext eol=lfso this can't happen. All three current snapshots are already LF (verified withfile); the attribute ensures it stays that way.Test plan
file workspace/tests/snapshots/*.txtconfirms all three are ASCII/UTF-8 text (LF).gitattributesmatches the pattern style used for other LF-pinned files in this repo (*.sh,*.py,Dockerfile)Refs: #2258 review.