Skip to content

chore(deps): batch dep bumps — 6 safe upgrades (4 actions majors + 2 npm dev deps) - #2246

Merged
HongmingWang-Rabbit merged 1 commit into
stagingfrom
chore/all-deps-batch-2026-04-28-pt2
Apr 29, 2026
Merged

HongmingWang-Rabbit merged 1 commit into
stagingfrom
chore/all-deps-batch-2026-04-28-pt2

Conversation

@HongmingWang-Rabbit

Copy link
Copy Markdown
Contributor

Summary

One PR for all 6 remaining safe-to-merge dependabot bumps from the 2026-04-28 wave. Replaces three single-bump PRs (#2245, #2230, #2231) closed in favor of this consolidated batch — same pattern as the earlier #2235.

Bumps

GitHub Actions majors (SHA-pinned)

Action From To Closes
`github/codeql-action` v3 v4.35.2 #2228
`actions/setup-node` v4 v6.4.0 #2218
`actions/upload-artifact` v4 v7.0.1 #2216
`actions/setup-python` v5 v6.2.0 #2214

npm dev deps (canvas/)

Dep From To Closes
`@types/node` ^22 ^25.6 #2231
`jsdom` ^25 ^29.1 #2230

Lockfile regenerated in `node:22-bookworm` Docker container so Linux-only optional deps (`@emnapi/*`) are properly included. Mac-native `npm install` strips them — that's why the earlier #2235 batch had to drop these.

Why each is safe

  • setup-node v4 → v6 / setup-python v5 → v6: every consumer pins `node-version` (`'20'` or `'22'`) / `python-version` (`'3.11'`). Default-version drift in v5/v6 is invisible to pinned consumers.
  • codeql-action v3 → v4.35.2: `init`/`autobuild`/`analyze` only. v4 bundles newer CodeQL CLI; ubuntu-latest auto-updates. We don't use the deprecated `CODEQL_ACTION_CLEANUP_TRAP_CACHES` env var.
  • upload-artifact v4 → v7.0.1: v6 requires Actions Runner ≥ 2.327.1 (Node.js 24 runtime). All consumers (`codeql.yml`, `e2e-staging-canvas.yml`) run on `ubuntu-latest` which auto-updates.
  • @types/node 22 → 25 / jsdom 25 → 29: dev-only — type definitions and vitest's DOM env. 1154/1154 tests pass in node:22-bookworm container.

Verified locally (Linux container)

  • `docker run … npm install --include=optional` → 169 packages, lockfile includes `@emnapi/*`
  • `docker run … npm test` → 79 files / 1154 tests pass
  • `docker run … npm ci` → clean install succeeds
  • `docker run … npm run build` → Next.js prerendering succeeds
  • All YAML still valid; SHA pins preserve `# vX.Y.Z` comments per org convention

Held back (not merged — code-migration tasks, not auto-bumps)

These need real engineering work; flag them as tracked tasks rather than try-and-fail merges.

🤖 Generated with Claude Code

…npm dev deps)

Consolidates the remaining safe-to-merge dependabot PRs from the
2026-04-28 wave into one consumable PR. Replaces three earlier
single-bump PRs (#2245, #2230, #2231) which were closed in favor of
this single batch — same pattern as #2235.

GitHub Actions majors (SHA-pinned per org convention):
  github/codeql-action       v3 → v4.35.2  (#2228)
  actions/setup-node         v4 → v6.4.0   (#2218)
  actions/upload-artifact    v4 → v7.0.1   (#2216)
  actions/setup-python       v5 → v6.2.0   (#2214)

npm dev deps (canvas/, lockfile regenerated in node:22-bookworm
container so @emnapi/* and other Linux-only optional deps are
properly resolved — Mac-native `npm install` strips them, which
caused the earlier #2235 batch to drop these two):
  @types/node                ^22 → ^25.6   (#2231)
  jsdom                      ^25 → ^29.1   (#2230)

Why each is safe

  setup-node v4 → v6 / setup-python v5 → v6:
    Every consumer call pins node-version / python-version
    explicitly. v5 / v6 changed defaults but pinned consumers
    are unaffected. Confirmed via grep across .github/workflows/
    — all setup-node call sites pin '20' or '22', all
    setup-python call sites pin '3.11'.

  codeql-action v3 → v4.35.2:
    Used as init/autobuild/analyze sub-actions in codeql.yml.
    v4 bundles a newer CodeQL CLI; ubuntu-latest auto-updates
    so functional behavior is unchanged. The deprecated
    CODEQL_ACTION_CLEANUP_TRAP_CACHES env var (per v4.35.2
    release notes) is undocumented and we don't set it.

  upload-artifact v4 → v7.0.1:
    v6 introduced Node.js 24 runtime requiring Actions Runner
    >= 2.327.1. All upload-artifact users (codeql.yml,
    e2e-staging-canvas.yml) run on `ubuntu-latest` (GitHub-
    hosted), which auto-updates the runner agent. Self-hosted
    runners are NOT used for these jobs.

  @types/node 22 → 25 / jsdom 25 → 29:
    Both are dev-only — @types/node is type definitions,
    jsdom backs vitest's DOM environment. Tests pass:
    79 files / 1154 tests in node:22-bookworm container.

Verified locally (Linux container so the lockfile reflects what
CI's `npm ci` will install):
  - cd canvas && npm install --include=optional → 169 packages
  - npm test → 1154/1154 pass
  - npm ci → clean install succeeds
  - npm run build → Next.js prerendering succeeds

Closes when this lands (the 3 individual auto-merge PRs from earlier
were closed):
  #2228 #2218 #2216 #2214 #2231 #2230

NOT included (CI failing on dependabot's own run — major framework
bumps that need code-side migration tasks, not safe auto-bumps):
  #2233 next 15 → 16
  #2232 tailwindcss 3 → 4
  #2226 typescript 5 → 6
@HongmingWang-Rabbit
HongmingWang-Rabbit added this pull request to the merge queue Apr 29, 2026
Merged via the queue into staging with commit c68ea3a Apr 29, 2026
23 of 24 checks passed
@HongmingWang-Rabbit
HongmingWang-Rabbit deleted the chore/all-deps-batch-2026-04-28-pt2 branch April 29, 2026 00:52
HongmingWang-Rabbit pushed a commit that referenced this pull request Jun 12, 2026
…ser credential (#2245)' (#2246) from fix/2245-platform-managed-no-cred into main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant