fix(ci): auto-promote gate-check uses workflow file paths, not names - #2204
Merged
hongmingwang-moleculeai merged 1 commit intoApr 28, 2026
Merged
Conversation
Observed 2026-04-28: auto-promote ran for staging head 96955f7 with all gates actually green (verified via /commits/<sha>/check-runs API) yet `check-all-gates-green` reported `CodeQL → missing/none` and aborted. Same SHA was promotable; auto-promote couldn't see it. Cause: `gh run list --workflow="CodeQL"` matched two workflows in this repo: - codeql.yml (explicit, scans both staging and main) - codeql (GitHub UI-configured Code-quality default setup, internal, scans default branch only) gh CLI rejects ambiguous `--workflow=<name>` lookups and returns no result → the gate fell through to `missing/none` and ALL_GREEN was set false. Every staging push since both names existed has been silently dead-locked. Fix: switch GATES from display-name strings to workflow file paths. File paths are the unique identifier for a workflow file in .github/workflows/; display names are decoration and can collide. The same `gh run list --workflow=<file.yml>` query that fails on "CodeQL" succeeds on "codeql.yml" because the file path resolves unambiguously. No behavior change for the other three gates (CI, E2E Canvas, E2E API Smoke) since their names didn't collide — they keep working, they just identify by ci.yml / e2e-staging-canvas.yml / e2e-api.yml now. The log line shape changes from `CI → completed/success` to `ci.yml → completed/success` which is fine for ops grep. When adding/removing a gate going forward: file paths only. Keep branch-protection required-checks (check-run display names) in sync as a separate manual step. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
HongmingWang-Rabbit
requested a review
from hongmingwang-moleculeai
as a code owner
April 28, 2026 20:15
HongmingWang-Rabbit
pushed a commit
that referenced
this pull request
Jun 12, 2026
Reasoning models (MiniMax M2.7, Moonshot K2.6) can spend the entire 4-token budget on reasoning, leaving zero tokens for the actual response. Bump the per-provider liveness probe to 32 so reasoning models have headroom to emit both reasoning and content. Part of issue #2204. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Auto-promote ran for staging head `96955f7b` with all gates actually green (verified via `/commits//check-runs` API) but reported `CodeQL → missing/none` and aborted. Same SHA was promotable; auto-promote couldn't see it.
Cause
`gh run list --workflow="CodeQL"` matched two workflows:
gh CLI rejects ambiguous `--workflow=` lookups → empty result → gate fell to `missing/none` → `ALL_GREEN=false` → promote skipped. Every staging push since both names existed was silently dead-locked.
Fix
Switch `GATES` from display names to workflow file paths in `auto-promote-staging.yml`:
```diff
GATES=(
)
```
File paths are the canonical identifier for workflow files; display names are decoration and can collide.
Why this over renaming
The alternative would be renaming `codeql.yml`'s `name:` to disambiguate. That:
Using file paths is structurally correct and immune to future name collisions.
Sequence after this lands
Test plan
🤖 Generated with Claude Code