docs(ci): correct overstated comments in publish + pin-compat workflows - #2198
Closed
HongmingWang-Rabbit wants to merge 1 commit into
Closed
docs(ci): correct overstated comments in publish + pin-compat workflows#2198HongmingWang-Rabbit wants to merge 1 commit into
HongmingWang-Rabbit wants to merge 1 commit into
Conversation
Two doc-only fixes from the post-merge review of #2196 + #2197. publish-runtime.yml (cascade pip-resolve probe): - Comment said "≈ 2 min" but real wall is 30 attempts × (~3-5s pip install + 4s sleep) ≈ 4-5 min on a slow runner. Update both the in-loop comment and the final ::error:: message. - Add the `--no-cache-dir` caveat to the comment block so the next reader doesn't assume this probe defends against ALL Fastly failure modes. It defends against propagation lag (the cascade- too-fast case it was added to fix); it does NOT defend against Fastly serving stale CONTENT under the new version's URL — that's a separate PyPI-corruption mode that needs a wheel-hash check against the just-uploaded dist (tracked as a follow-up). runtime-pin-compat.yml (PR-built wheel job): - Comment said "byte-identical with publish-runtime.yml's build step" but the temp dirs differ (`/tmp/runtime-build` here vs `${{ runner.temp }}/runtime-build` there — they coincide on ubuntu-latest but call sites aren't identical). Soften to "same build script with the same args" and explicitly call out that the smoke import is intentionally narrower than publish's full invariant battery. No behavior change. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
HongmingWang-Rabbit
requested a review
from hongmingwang-moleculeai
as a code owner
April 28, 2026 17:14
HongmingWang-Rabbit
enabled auto-merge
April 28, 2026 17:14
3 tasks
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Apr 28, 2026
Contributor
Author
|
Obsoleted by #2199 + #2200 which both substantially restructured the same comment regions:
Both target comments are now correct on staging without this PR. |
HongmingWang-Rabbit
pushed a commit
that referenced
this pull request
Jun 12, 2026
) The canvas-readiness loop added in PR #2195 captured the curl status into CODE with `CODE=$(curl -s -o /dev/null -w '%{http_code}' ... || echo 000)`. That shape is exactly the BAD_STATUS_CAPTURE pattern that .gitea/scripts/lint-curl-status-capture.py rejects — curl -w can write a status to stdout before the || echo 000 fallback fires, producing polluted values such as a concatenated status string rather than one code. Adopt the lint-approved tempfile pattern already used by e2e-staging-external.yml (set +e / curl -w '...' > file / set -e / cat file || echo '000') so the captured value is always a clean HTTP code or '000'. Closes #2198 (main-red after #2195). Closes #2199 (auto-filed main-red watchdog, root cause identical to #2198). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two doc-only fixes from the post-merge review of #2196 + #2197:
publish-runtime.yml— comment claimed "≈ 2 min" but real wall is ~4-5 min (30 attempts × (~3-5s pip install + 4s sleep) on a slow runner). Updated both the comment and the final::error::message. Also added a caveat about Fastly content-under-URL staleness (separate from propagation lag — needs a follow-up wheel-hash check).runtime-pin-compat.yml— comment claimed "byte-identical with publish-runtime.yml's build step" but the temp dirs differ (/tmp/runtime-buildhere vs${{ runner.temp }}/runtime-buildthere). Softened to "same build script with the same args" and noted the smoke import is intentionally narrower than publish's.No behavior change
Comment-only edits.
🤖 Generated with Claude Code