fix(ci): stop sweep-cf-orphans noise — drop merge_group + soft-skip when secrets unset - #2098
Merged
Merged
Conversation
…hen secrets unset The sweep-cf-orphans workflow shipped in #2088 was noisier than intended in two ways. This PR fixes both — was filed under the Optional finding I left on the original review and now matters because the noise is observably hitting the merge queue. 1) `merge_group: types: [checks_requested]` was firing the entire sweep job on every PR through the merge queue. The original intent ("future required-check support without a workflow edit") never materialized, and meanwhile every recent merge-queue eval (#2091, #2092, #2093, #2094, #2095, #2097) generated a red `Sweep CF orphans (merge_group)` run. Drop the trigger. Comment in the workflow explains the re-add path if/when the workflow IS wired as a required check (re-add the trigger AND gate the actual sweep step with `if: github.event_name != 'merge_group'` so merge-queue evals are no-op success). 2) The `Verify required secrets present` step exits 2 when the 6 secrets aren't configured yet (the PR body's post-merge step, still pending). That turns the hourly schedule into an hourly red CI run for as long as the secrets stay unset. Convert to a soft skip: emit a `::warning::` listing the missing secrets and set a `skip=true` step output, then gate the sweep step with `if: steps.verify.outputs.skip != 'true'`. Workflow reports green and ops still sees the warning when they review recent runs. Net effect: - merge-queue evals stop generating spurious red runs - the schedule reports green-with-warning until secrets land - once secrets land, behavior is identical to today's (real sweep runs, hard-fails if a secret is later removed) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
HongmingWang-Rabbit
enabled auto-merge
April 26, 2026 15:06
HongmingWang-Rabbit
pushed a commit
that referenced
this pull request
Jun 12, 2026
…e SSOT' (#2098) from feat/minimax-m3-sync into main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The `sweep-cf-orphans` workflow shipped in #2088 was noisier than intended in two ways. This PR fixes both — was filed under the Optional finding I left on the original review and now matters because the noise is observably hitting the merge queue (every recent PR through the merge queue generated a red `Sweep CF orphans (merge_group)` run, plus the hourly schedule fires red continuously while secrets are unset).
Two fixes
1) Drop `merge_group` trigger
Was firing the entire sweep job on every PR going through the merge queue:
Comment in the workflow explains the re-add path if/when this workflow IS wired as a required check (re-add the trigger AND gate the sweep step with `if: github.event_name != 'merge_group'`).
2) Soft-skip secret check
`Verify required secrets present` previously `exit 2`'d when secrets weren't configured yet (the PR body's post-merge step, still pending). That meant the hourly schedule was painting red continuously.
Convert to:
Workflow reports green-with-warning while secrets stay unset; once they land, behavior is identical to today's (real sweep runs, hard-fails if a secret is later removed).
Test plan
🤖 Generated with Claude Code