refactor(canvas): remove RUNTIME_PROFILES.hermes — value flows server-side (#2054 phase 3) - #2096
Conversation
…-side now (#2054 phase 3) Closes the canvas-side loop on #2054. Phases 1+2 plumbed provision_timeout_ms from template manifest → workspace API → canvas socket → node-data → ProvisioningTimeout resolver. The template-hermes manifest declares provision_timeout_seconds: 720 (filed as a separate template-repo PR). With that flow live, the canvas-side hardcoded RUNTIME_PROFILES.hermes entry is redundant. Removed: - RUNTIME_PROFILES.hermes (was 720000ms hardcoded in canvas/src/lib/runtimeProfiles.ts) Doc updates: - RUNTIME_PROFILES jsdoc explains the map is now empty by design — new runtimes that need a non-default cold-boot threshold should declare runtime_config.provision_timeout_seconds in their template manifest, NOT add an entry here. Tests updated (3): - "returns hermes override when runtime = hermes" → "hermes returns default — value moved server-side post-#2054 phase 3". Asserts RUNTIME_PROFILES.hermes is undefined. - The two server-override tests now compare against DEFAULT_RUNTIME_PROFILE since hermes no longer has a profile entry. 19/19 pass locally. The end-state for hermes: workspace-server reads template manifest at request time → workspace API includes provision_timeout_ms: 720000 → canvas hydrate populates node.data.provisionTimeoutMs → ProvisioningTimeout resolver picks it up via overrides. Same effective threshold (720s), now declarative and one-edit-point per runtime. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Reviewed across all five axes — logical approve (clean phase-3 cleanup, post-merge state matches the documented end-state flow), but Canvas tabs E2E is failing. Skip — failing CI: A retry or staging-side fix should clear this. Not arming auto-merge here per the review rules — please re-run the E2E job (or wait for the staging tenant-provisioning path to recover) and ping back if it still fails after that. Logical review notes for when CI clears:
|
|
Status update: Canvas tabs E2E retried at 15:47Z after #2099 (TLS timeout 3min→10min) merged at 15:27Z. The TLS timeout symptom is gone, but the suite now fails at a different point: This is a separate staging-orchestration issue, not anything this PR's diff introduced. The test creates an org via Still skipping merge per the review rules — this is the same skip reason (failing E2E, environmental) but a fresh root cause. Suggest filing a separate issue for the org-create→token-fetch 404 once it's been reproduced enough to characterize, then re-run E2E on this PR. |
|
Re-triggered failed CI (CP #284 just merged at 21:49Z, fixing the silent-DNS-failure root cause that was stranding tests at |
[Molecule-Platform-Evolvement-Manager]
Final canvas-side cleanup for #2054. The hardcoded `RUNTIME_PROFILES.hermes = 720_000ms` entry is redundant now that the value flows from the template manifest through workspace-server to the canvas socket payload.
End-state flow for hermes
Same effective 720s threshold, now declarative and one-edit-point per runtime.
Changes
Tests
19/19 pass. The deleted hermes override is replaced by an assertion that `RUNTIME_PROFILES.hermes` is `undefined` — locks in the post-cleanup state so a future re-add gets caught.
Test plan
Related PRs in this chain