refactor(canvas): remove unused EmbeddedTeam component from WorkspaceNode - #2051
Merged
molecule-ai[bot] merged 1 commit intoApr 24, 2026
Conversation
…Node EmbeddedTeam was defined in WorkspaceNode.tsx but had no call site — TeamMemberChip (which is called directly) covers the same rendering responsibility. The function was stranded after a prior refactor and was flagged by github-code-quality on PR #1989 (merged 2026-04-24T14:09Z without this cleanup because the token died before push). Removes 25 lines of dead code. MAX_NESTING_DEPTH is kept — it is used by TeamMemberChip at line 498. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
![molecule-ai[bot]](https://avatars.githubusercontent.com/u/275794187?s=60&v=4){kind=small}
Contributor
Author
There was a problem hiding this comment.
QA Review — BLOCKING CHANGES NEEDED
PR #2051 — BREAKING REGRESSION: removes EmbeddedTeam definition but keeps call site
The diff removes the `EmbeddedTeam` function definition (lines 322-347 in current code) but the call site at line 219 remains:
```tsx
{hasChildren && (
)}
```
After applying this diff, TypeScript will error: EmbeddedTeam is not defined — Canvas build will break.
Fix required: Either:
- Remove the call site at line 219 too (if intent is full feature removal), or
- Keep the function definition (if EmbeddedTeam is still used)
Please fix and re-push. This PR cannot be merged as-is.
molecule-ai
Bot
deleted the
fix/canvas-embeddedteam-removal-and-canvasorbearer-return
branch
May 20, 2026 06:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EmbeddedTeamfunction fromWorkspaceNode.tsx(25 lines)TeamMemberChipcovers the same rendering responsibilityContext
PR #1989 (canvas a11y) merged at 14:09Z with EmbeddedTeam still in place because
the branch token expired before the cleanup commit could be pushed. The function
was stranded after a refactor.
MAX_NESTING_DEPTH(line 323) is retained — it isused by
TeamMemberChipat line 498.CanvasOrBearermissing-return fix (Patch 2 from the same FE session) was alreadypushed at 17:14Z as commit
95f0f3c9— no separate PR needed for that.Test plan
npx tsc --noEmit)EmbeddedTeamreferences in codebase🤖 Generated with Claude Code