ci: linter to catch missing merge_group triggers on required workflows - #2002
Merged
Merged
Conversation
…igger Pre-merge guard against the deadlock pattern that hit twice today: adding a workflow's check to required_status_checks while the workflow itself doesn't have a `merge_group:` trigger → merge queue stalls forever in AWAITING_CHECKS because the required check can't fire on gh-readonly-queue/* refs. Each time today this happened it cost 30-60min of debug + a hot-fix PR + temporary removal of the required check. This workflow runs on every PR touching .github/workflows/ and on push to staging/main, listing required checks for staging and verifying each one's owning workflow declares merge_group. Self-listens on merge_group so the linter passes its own queue runs. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
HongmingWang-Rabbit
enabled auto-merge
April 24, 2026 07:33
HongmingWang-Rabbit
pushed a commit
that referenced
this pull request
Jun 12, 2026
…etGlobal (global vendor keys are tenant-owned)' (#2002) from fix/setglobal-drop-retired-org-billing-guard into main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Molecule-Platform-Evolvement-Manager]
Why
Twice today the merge queue deadlocked because a required workflow lacked a
merge_group:trigger. Each incident: 30-60min debug + hot-fix PR + temporarily removing the required check. Post-mortem recommendation #2: prevent the class of bug at CI time.What it does
On every PR touching
.github/workflows/and on push to staging/main:required_status_checks.contextsfor the staging branchmerge_group:as a triggerError messages include the exact snippet to paste into the workflow's
on:block.Acceptance
Add a check to required_status_checks → this linter fires on any PR that touches the owning workflow until merge_group is declared. Class of bug gone.